New issue
Advanced search Search tips

Issue 708273 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

move run_oci to its own directory

Project Member Reported by smbar...@chromium.org, Apr 4 2017

Issue description

container_utils is getting utilities that are useful for adb/fastboot, but not so much for termina at the moment.

Rather than having USE flags to conditionally add every target in container_utils, move run_oci to its own directory and ebuild.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/38f859a9e0a034372f6ffb67d179af1634fd1ad3

commit 38f859a9e0a034372f6ffb67d179af1634fd1ad3
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Apr 06 08:42:16 2017

run_oci: create new ebuild for run_oci

Split run_oci from container_utils into its own ebuild, and add a dependency
on run_oci with USE=containers.

BUG= chromium:708273 
TEST=USE=containers ./build_packages --board=samus
CQ-DEPEND=CL:468107

Change-Id: I95fca829a922678765acba4966e67ea8bd137614
Reviewed-on: https://chromium-review.googlesource.com/468027
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/38f859a9e0a034372f6ffb67d179af1634fd1ad3/chromeos-base/container_utils/container_utils-9999.ebuild
[add] https://crrev.com/38f859a9e0a034372f6ffb67d179af1634fd1ad3/chromeos-base/run_oci/run_oci-9999.ebuild
[modify] https://crrev.com/38f859a9e0a034372f6ffb67d179af1634fd1ad3/virtual/target-chromium-os/target-chromium-os-1.ebuild
[rename] https://crrev.com/38f859a9e0a034372f6ffb67d179af1634fd1ad3/virtual/target-chromium-os/target-chromium-os-1-r66.ebuild

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/6aadc551d8f927630ebe44150f2ffac9aa53869a

commit 6aadc551d8f927630ebe44150f2ffac9aa53869a
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Apr 06 08:42:16 2017

termina: depend on new run_oci ebuild

BUG= chromium:708273 
TEST=build tatl image, ensure it includes run_oci binary
CQ-DEPEND=CL:468027

Change-Id: I8f9a55c715ed12124a04d27dee770c4616b698e5
Reviewed-on: https://chromium-review.googlesource.com/468048
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/6aadc551d8f927630ebe44150f2ffac9aa53869a/project-termina/virtual/target-termina-os/target-termina-os-1.5-r3.ebuild
[modify] https://crrev.com/6aadc551d8f927630ebe44150f2ffac9aa53869a/project-termina/virtual/target-termina-os/target-termina-os-1.5.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/5f6dc9b19365b37277860b260cccde6b6838adb0

commit 5f6dc9b19365b37277860b260cccde6b6838adb0
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Apr 06 08:42:16 2017

container_utils: pull out run_oci into its own package

BUG= chromium:708273 
TEST=emerge-tatl run_oci
CQ-DEPEND=CL:468027

Change-Id: I6873260887d1cbc072d09753c5c29ad028bb606e
Reviewed-on: https://chromium-review.googlesource.com/468107
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/5f6dc9b19365b37277860b260cccde6b6838adb0/run_oci/container_config_parser.cc
[modify] https://crrev.com/5f6dc9b19365b37277860b260cccde6b6838adb0/container_utils/container_utils.gyp
[rename] https://crrev.com/5f6dc9b19365b37277860b260cccde6b6838adb0/run_oci/container_config_parser.h
[rename] https://crrev.com/5f6dc9b19365b37277860b260cccde6b6838adb0/run_oci/container_options.h
[rename] https://crrev.com/5f6dc9b19365b37277860b260cccde6b6838adb0/run_oci/run_oci.cc
[rename] https://crrev.com/5f6dc9b19365b37277860b260cccde6b6838adb0/run_oci/container_config_parser_unittest.cc
[add] https://crrev.com/5f6dc9b19365b37277860b260cccde6b6838adb0/run_oci/README.md
[add] https://crrev.com/5f6dc9b19365b37277860b260cccde6b6838adb0/run_oci/run_oci.gyp
[rename] https://crrev.com/5f6dc9b19365b37277860b260cccde6b6838adb0/run_oci/oci_config.h

Status: Fixed (was: Untriaged)

Comment 5 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Components: OS>Systems>Containers

Comment 9 by vapier@chromium.org, May 17 2018

Labels: -Restrict-View-Google
Status: Fixed (was: Archived)

Sign in to add a comment