New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708264 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Motion for Clipboard URL suggest on iOS NTP

Project Member Reported by emilyschechter@chromium.org, Apr 4 2017

Issue description

From ainslie:

From the NTP, I think [the funkiness] is because of how the single-copied-URL-suggestion animates down (in Y) while the rest of the NTP UI is flying in the opposite direction and the omnibox is expanding (in X).

Helen, could you help confirm the correct behavior?
 
Components: UI>Browser>Omnibox

Comment 2 by sczs@chromium.org, Apr 5 2017

Cc: -helenepark@chromium.org justincohen@chromium.org rohitrao@chromium.org
Owner: helenepark@chromium.org
Status: Assigned (was: Untriaged)
Notes from meeting with Helene:

Suggestion should follow implied movement from omnibox -- from a few pixels below, move up, with the same motion curve & timing as the omnibox.

(Android should also do this, if it looks like same).
Helene, to confirm, do you think the suggestion should appear immediately upon tapping the omnibox in the middle of the page and move up while being attached to it?
Cc: jif@chromium.org
CC jif@, who worked on clipboard suggestions on iOS
To clarify:

Right now, the omnibox animates up, then the suggestion text appears, and moves down.

Ideally, the omnibox animates up, then the suggestion text appears, and move up.


Re: Comment 3
Yes, the suggestion should appear immediately as it does currently, with the only adjustment being the position moving upward. Currently it moves downwards. The motion curve and timing should be preserved

Re: comment 6
Yes, the suggestion text should follow the momentum of the omnibox - the omnibox may not be literally moving but its implied motion is visualized in this attached video


copiedlink.mov
3.2 MB Download
Cc: helenepark@chromium.org
Components: -UI>Browser>Omnibox UI>Browser>Omnibox>ZeroSuggest
Labels: Hotlist-Polish
Owner: ----
Status: Available (was: Assigned)
We'll see what it takes to fix this if/when we turn on zero suggest for iOS, as that will dramatically increase the number of people who see the current imperfect motion.
Blocking: 725120
I think inverting the cell label animate-in direction like Hélène suggests would definitely help and be nice polish, but I don't think it is actually the culprit to the funkiness Alex mentions.

Assuming I'm seeing what everyone else is, what makes things feel broken here is the fact the *non-NTP* Omnibox unfocused -> focused state animation is playing out. We already have a working animation for the NTP when there is no completions view (no clipboard item) and we need to adjust that to work with the optionally visible completion view (which should probably fade-in and animate up, following the Omnibox). See the attached videos to better understand what I'm talking about.

Fixing this should make the animation feel much less funky and at that point, we can discuss if Hélène's suggested improvements are needed.
no_clipboard_URL.mov
6.2 MB Download
clipboard_URL.mov
4.3 MB Download
Blocking: -725120
Cc: -jif@chromium.org stkhapugin@chromium.org
Components: -UI>Browser>Omnibox>ZeroSuggest UI>Browser>NewTabPage
Owner: pschaffner@chromium.org
Status: Assigned (was: Available)
Pete, please confirm that it's fixed now: In UI Refresh, we open the popup after the NTP animation is complete. I think it looks okay now. 
Status: Fixed (was: Assigned)

Sign in to add a comment