New issue
Advanced search Search tips

Issue 708251 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
emir...@chromium.org
mcasas@chromium.org
chfremer@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

VideoCaptureManager simplification if no code requires synchronous failure if device does not exist

Project Member Reported by chfremer@chromium.org, Apr 4 2017 
See VideoCaptureManager::ProcessDeviceStartRequestQueue() [1].

The unit test VideoCaptureManagerTest.OpenNotExisting requires us to fail synchronously if the stream_type is MEDIA_DEVICE_VIDEO_CAPTURE and no DeviceInfo matching the requested id is present (which is the case when requesting a device with a bogus id). Note, that since other types of failure during startup of the device are allowed to be reported asynchronously, this requirement is questionable.

Check if any production code actually depends on this requirement. If not, relax the requirement in the test and simplify.

[1] https://cs.chromium.org/chromium/src/content/browser/renderer_host/media/video_capture_manager.cc?q=VideoCaptureManager&dr=CSs&l=294
Project Member

Comment 1 by sheriffbot@chromium.org, Apr 6 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
►

Sign in to add a comment