New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 708248 link

Starred by 1 user
Status: Fixed
Owner:
qin...@chromium.org
Closed: Apr 2017
Cc:
█ dah...@chromium.org
xingliu@chromium.org
dtrainor@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Investigate whether UMA stats are valid for ParallelDownload

Project Member Reported by qin...@chromium.org, Apr 4 2017 
Chrome Version: 59

The parallel download stats are sometimes contradicting. With parallel requests, the speed is lower, but the time saved is positive.
And I sometimes saw more than 1000 seconds of time saved, which is wierd.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d91c32221adad968b718754a00a6fc4573340e6b

commit d91c32221adad968b718754a00a6fc4573340e6b
Author: qinmin <qinmin@chromium.org>
Date: Wed Apr 05 21:25:33 2017

Fix the UMA stats calculation because of overflow

size_t can be 32 bit, and it can easily overflow when calculating bandwidth.

BUG= 708248 

Review-Url: https://codereview.chromium.org/2798723002
Cr-Commit-Position: refs/heads/master@{#462221}

[modify] https://crrev.com/d91c32221adad968b718754a00a6fc4573340e6b/content/browser/download/download_stats.cc

Comment 2 by qin...@chromium.org, Apr 5 2017

Status: Fixed (was: Started)
►

Sign in to add a comment