Importer is now trying to import -manual.html tests that were not imported before. |
||||
Issue descriptionAfter https://codereview.chromium.org/2786013003, the test_copier.py no longer uses TestParser; TestParser had a rule to check whether files are manual tests (they have "-manual." in the filename). Previously manual tests in wpt were not imported; after that change, they are. Since we still want to remove test_parser.py ( bug 706919 ), I think we still want to avoid using TestParser. Quick fix: In test_copier.py skip tests that have "-manual." in the filename. General change: When finding tests, don't consider tests from the "manual" test part of MANIFEST.json as tests, and don't run them? Does that sound right?
,
Apr 5 2017
Can we update the importer so that adding [ Skip ] expectation for tests of which names match to *-manual.* and try results are Timeout or Missing? In Chromium project, we have three classes of WPT manual tests: A) Using testharness.js, and we have wpt_automation for the test B) Using testharness.js, and we have no wpt_automation C) Using no testharness.js We imported A+B, and had to exclude B manually. Even if we can distinguish A/B and C by looking MANIFEST.json, we still need manual exclusion for B. It would be nice to have a way to skip/exclude B+C automatically.
,
Apr 5 2017
Good point. This will mean that we'll import all of the tests (A+B+C), and have Skip expectations for B+C, which will probably end up being 100s of lines in TestExpectations. This might not be ideal in the long run, but I think it's a good way to proceed for now. Made CL https://codereview.chromium.org/2799683003.
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a55b708afc1a74f2f120d1c473a5f0673a1974f commit 2a55b708afc1a74f2f120d1c473a5f0673a1974f Author: qyearsley <qyearsley@chromium.org> Date: Thu Apr 06 17:40:45 2017 Add skip expectations for new manual tests with a missing or timeout result. BUG= 708241 Review-Url: https://codereview.chromium.org/2799683003 Cr-Commit-Position: refs/heads/master@{#462533} [modify] https://crrev.com/2a55b708afc1a74f2f120d1c473a5f0673a1974f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py [modify] https://crrev.com/2a55b708afc1a74f2f120d1c473a5f0673a1974f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py
,
Apr 7 2017
So, for now, skip expectations will be added, and this should be OK, at least for now.
,
Apr 10 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by qyears...@chromium.org
, Apr 4 2017Status: Assigned (was: Unconfirmed)