New issue
Advanced search Search tips

Issue 708236 link

Starred by 1 user
Status: Fixed
Owner:
dtapu...@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 717205



Sign in to add a comment

TouchpadFlingScroll can hit NOTREACHED case in switch

Reported by brandon....@oculus.com, Apr 4 2017 
Chrome Version: 56.0.2924.87
OS: Android
URL (if applicable) where crash occurred: tmz.com

Can you reproduce this crash?
Yes, in Oculus Browser (and maybe VrShell)

What steps will reproduce this crash (or if it's not reproducible,
what were you doing just before the crash)?
(1) EventListenerProperties are kBlockingAndPassive
(2) InputHandler goes down TouchpadFlingScroll route (Oculus Browser has these conditions on tmz.com due to how gestures are generated)

Causes a crash due to NOTREACHED in debug builds.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/742bb98afe29eff3d693328bc39a62f680f83a1d

commit 742bb98afe29eff3d693328bc39a62f680f83a1d
Author: Brandon.Furtwangler <Brandon.Furtwangler@oculus.com>
Date: Thu Apr 06 17:59:29 2017

Adds missing kBlockingAndPassive case to TouchpadFlingScroll

While debugging an issue for Oculus Browser I hit the NOTREACHED case in TouchpadFlingScroll on tmz.com.  This causes a crash in debug builds.  Oculus Browsers gestures flings are based on vr_input_manager, so this likely applies to vr_shell as well.

BUG= 708236 

Review-Url: https://codereview.chromium.org/2793403002
Cr-Commit-Position: refs/heads/master@{#462541}

[modify] https://crrev.com/742bb98afe29eff3d693328bc39a62f680f83a1d/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/742bb98afe29eff3d693328bc39a62f680f83a1d/ui/events/blink/input_handler_proxy_unittest.cc

Comment 2 by rbyers@chromium.org, May 4 2017

Components: Blink>Input
Labels: -Restrict-View-EditIssue
Owner: dtapu...@chromium.org
Status: Fixed (was: Unconfirmed)

Comment 3 by rbyers@chromium.org, May 4 2017

Blocking: 717205
Labels: M-60
This was apparently the root cause of some fling issues we saw in  issue 717205

Comment 4 by dtapu...@chromium.org, May 4 2017

Labels: -M-60 M-59
►

Sign in to add a comment