New issue
Advanced search Search tips

Issue 708226 link

Starred by 1 user
Status: Fixed
Owner:
tmartino@chromium.org
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

[WebPayments] Create string_util for fetching UI strings cross-platform

Project Member Reported by tmartino@chromium.org, Apr 4 2017 
There are some methods in the Desktop PR implementation that fetch the appropriate string for display in certain situations. We need to move these to components so iOS can use them too.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c32cf8a6e0185d51a16fbe3904e77043758e7ce

commit 9c32cf8a6e0185d51a16fbe3904e77043758e7ce
Author: tmartino <tmartino@chromium.org>
Date: Tue Apr 04 20:34:39 2017

Move string helper functions to components/core for iOS use.

BUG= 708226 

Review-Url: https://codereview.chromium.org/2784973002
Cr-Commit-Position: refs/heads/master@{#461819}

[modify] https://crrev.com/9c32cf8a6e0185d51a16fbe3904e77043758e7ce/chrome/browser/ui/views/payments/payment_request_views_util.cc
[modify] https://crrev.com/9c32cf8a6e0185d51a16fbe3904e77043758e7ce/chrome/browser/ui/views/payments/payment_request_views_util.h
[modify] https://crrev.com/9c32cf8a6e0185d51a16fbe3904e77043758e7ce/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/9c32cf8a6e0185d51a16fbe3904e77043758e7ce/chrome/browser/ui/views/payments/profile_list_view_controller.cc
[modify] https://crrev.com/9c32cf8a6e0185d51a16fbe3904e77043758e7ce/chrome/browser/ui/views/payments/shipping_option_view_controller.cc
[modify] https://crrev.com/9c32cf8a6e0185d51a16fbe3904e77043758e7ce/components/payments/core/BUILD.gn
[modify] https://crrev.com/9c32cf8a6e0185d51a16fbe3904e77043758e7ce/components/payments/core/DEPS
[add] https://crrev.com/9c32cf8a6e0185d51a16fbe3904e77043758e7ce/components/payments/core/strings_util.cc
[add] https://crrev.com/9c32cf8a6e0185d51a16fbe3904e77043758e7ce/components/payments/core/strings_util.h

Comment 2 by tmartino@chromium.org, Jun 15 2017

Labels: OS-All
Status: Fixed (was: Started)
►

Sign in to add a comment