Question, was the incognito notification still present after the tabs were closed but before downloads home was closed? Also, did you manually close the tabs or close them using the incognito notification?

It seems like closing all tabs should make downloads home close as well. Otherwise it is a privacy leak. Rachelis@ thoughts?

I closed the tabs via the notification.

IMO, we should definitely be closing the downloads home. Leaving a vestige of incognito behavior behind when the user has asked to close all tabs is not what users intend.

This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

I reproduced it as:

1- Go to Incognito.
2- Download Something.
3- Open Download's Home.
4- Close Incognito using close all incognito tabs.
5- Downloads home is still open and downloaded file is visible.
6- Close Downloads home.
7- Open it again, and the file is not there anymore.

One can argue that the file is written to the device and so having a trace of it here is not important, but we at least needs consistency between 5 and 7, and this is something that may/will affect user trust.

I think we should fix it.

crbug.com/655378 says that download home should show all files downloaded from both incognito and normal mode.

This can be fixed by detecting profile close and removing all off the record downloads (or notifying all observers of the entries going away on destruction).

But crbug.com/655378 says incognito downloaded files should not be deleted.
Shouldn't one of these bugs be closed in favor of the other?

I don't think we need to do this if we properly remove incognito downloads from the UI when the incognito profile dies.  wdyt?

I think the privacy-correct behavior is:

1- All downloaded files from incognito and regular mode are shown in download home.
2- After closing incognito mode, downloaded files would not be removed from download home as they are already on disk.
3- After closing incognito mode, if download home is open, it stays open.

So I think when crbug.com/655378 is fixed, this bug can be marked as wont fix as it is the intended behavior.

r.e. #13 (2) - We lose all information about those downloads once the incognito profile is closed.  So we can potentially still show them for the session (although things could break), but if downloads home is closed and opened again they will be gone after the incognito profile was destroyed.