New issue
Advanced search Search tips

Issue 708212 link

Starred by 1 user
Status: Archived
Owner:
est...@chromium.org
Closed: Apr 2017
Cc:
sgabr...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

render phantom window programatically (with WM shadows)

Project Member Reported by est...@chromium.org, Apr 4 2017 
// PhantomWindowController is responsible for showing a phantom representation
// of a window. It's used to show a preview of how snapping or docking a window
// will affect the window's bounds.

Currently for this we tile some raster assets. Need spec for how to render without use of these assets.
dFiFXh4WoMA.png
41.2 KB View Download

Comment 1 by sgabr...@chromium.org, Apr 7 2017

Cc: sgabr...@chromium.org
Owner: est...@chromium.org
I've updated the shadow spec to include window phantoms:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZTZJtyyKAl3p/files/MCFYkQPDhRGy9ADk3WbFgPydwMSJbxAVNpw

Took this opportunity to revamp the behavior a bit:

- Fill is now White #FFF 40%
- Edges are snapped against the edges to reflect actual window positionning
- Shadow is now 24dp elevation.

Comment 2 by est...@chromium.org, Apr 17 2017

Status: Started (was: Assigned)

Comment 3 by tdander...@chromium.org, Apr 18 2017

Labels: M-60
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/871d538390b1c6c394176894f8b855d8b775d109

commit 871d538390b1c6c394176894f8b855d8b775d109
Author: estade <estade@chromium.org>
Date: Tue Apr 18 18:51:17 2017

Update ash phantom window aesthetics.

The phantom windows show where a dragged window will be snapped. This
uses asset-less rendering and normal WM shadows instead of tiling a
shadow asset.

BUG= 708212 

Review-Url: https://codereview.chromium.org/2825613002
Cr-Commit-Position: refs/heads/master@{#465304}

[modify] https://crrev.com/871d538390b1c6c394176894f8b855d8b775d109/ash/resources/ash_resources.grd
[delete] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/ash/resources/default_100_percent/common/phantom_window_bottom.png
[delete] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/ash/resources/default_100_percent/common/phantom_window_bottom_left.png
[delete] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/ash/resources/default_100_percent/common/phantom_window_bottom_right.png
[delete] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/ash/resources/default_100_percent/common/phantom_window_center.png
[delete] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/ash/resources/default_100_percent/common/phantom_window_left.png
[delete] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/ash/resources/default_100_percent/common/phantom_window_right.png
[delete] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/ash/resources/default_100_percent/common/phantom_window_top.png
[delete] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/ash/resources/default_100_percent/common/phantom_window_top_left.png
[delete] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/ash/resources/default_100_percent/common/phantom_window_top_right.png
[delete] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/ash/resources/default_200_percent/common/phantom_window_bottom.png
[delete] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/ash/resources/default_200_percent/common/phantom_window_bottom_left.png
[delete] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/ash/resources/default_200_percent/common/phantom_window_bottom_right.png
[delete] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/ash/resources/default_200_percent/common/phantom_window_center.png
[delete] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/ash/resources/default_200_percent/common/phantom_window_left.png
[delete] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/ash/resources/default_200_percent/common/phantom_window_right.png
[delete] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/ash/resources/default_200_percent/common/phantom_window_top.png
[delete] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/ash/resources/default_200_percent/common/phantom_window_top_left.png
[delete] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/ash/resources/default_200_percent/common/phantom_window_top_right.png
[modify] https://crrev.com/871d538390b1c6c394176894f8b855d8b775d109/ash/wm/workspace/phantom_window_controller.cc
[modify] https://crrev.com/871d538390b1c6c394176894f8b855d8b775d109/ui/wm/core/shadow_controller.cc
[modify] https://crrev.com/871d538390b1c6c394176894f8b855d8b775d109/ui/wm/core/shadow_controller.h

Comment 5 by est...@chromium.org, Apr 18 2017

Status: Fixed (was: Started)

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment