New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708202 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Participants' hotlists:
Fixing-touch


Sign in to add a comment

CURRENT orientation should use the current orientation of the app, instead of the desktop.

Project Member Reported by osh...@chromium.org, Apr 4 2017

Issue description

Currently, it uses the current desktop orientation, even if the application isn't active. For arc apps, we need to wait until the application gets activated and applies the previous orientation.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f5b7f72da4ca1534233252c673f9c162bdb25f9

commit 4f5b7f72da4ca1534233252c673f9c162bdb25f9
Author: oshima <oshima@chromium.org>
Date: Wed Apr 05 20:42:16 2017

Resolve current orientation after applying the previous orientation request.

An application may request to lock to portrait (primary/secondary), the
lock to specific orientation by sending CURRENT (no sensor/lock).
Current implement does not support this scenario because it looks to
the current device's orientation even if that orientation was for other apps.

This CL addresses this issue by waiting until the window is activated.

BUG= 708202 
TEST=covered by unit test, plus manual tests using sample app.

Review-Url: https://codereview.chromium.org/2792973002
Cr-Commit-Position: refs/heads/master@{#462206}

[modify] https://crrev.com/4f5b7f72da4ca1534233252c673f9c162bdb25f9/ash/content/screen_orientation_delegate_chromeos.cc
[modify] https://crrev.com/4f5b7f72da4ca1534233252c673f9c162bdb25f9/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/4f5b7f72da4ca1534233252c673f9c162bdb25f9/ash/display/screen_orientation_controller_chromeos.cc
[modify] https://crrev.com/4f5b7f72da4ca1534233252c673f9c162bdb25f9/ash/display/screen_orientation_controller_chromeos.h
[modify] https://crrev.com/4f5b7f72da4ca1534233252c673f9c162bdb25f9/ash/test/screen_orientation_controller_test_api.cc
[modify] https://crrev.com/4f5b7f72da4ca1534233252c673f9c162bdb25f9/ash/test/screen_orientation_controller_test_api.h
[modify] https://crrev.com/4f5b7f72da4ca1534233252c673f9c162bdb25f9/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/4f5b7f72da4ca1534233252c673f9c162bdb25f9/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Labels: Merge-Request-58
Cc: bhthompson@chromium.org
+bhthompson@ we need this for ARC++
Labels: -Merge-Request-58 Merge-Approved-58
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 8 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7112189d9a2fdcb0e0cfe7ff618d30aebadbb59b

commit 7112189d9a2fdcb0e0cfe7ff618d30aebadbb59b
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Sat Apr 08 05:30:22 2017

Resolve current orientation after applying the previous orientation request.

An application may request to lock to portrait (primary/secondary), the
lock to specific orientation by sending CURRENT (no sensor/lock).
Current implement does not support this scenario because it looks to
the current device's orientation even if that orientation was for other
apps.

This CL addresses this issue by waiting until the window is activated.

BUG= 708202 
TEST=covered by unit test, plus manual tests using sample app.

Review-Url: https://codereview.chromium.org/2792973002
Cr-Commit-Position: refs/heads/master@{#462206}
Committed:
https://chromium.googlesource.com/chromium/src/+/4f5b7f72da4ca1534233252c673f9c162bdb25f9

Review-Url: https://codereview.chromium.org/2802403002 .
Cr-Commit-Position: refs/branch-heads/3029@{#638}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/7112189d9a2fdcb0e0cfe7ff618d30aebadbb59b/ash/content/screen_orientation_delegate_chromeos.cc
[modify] https://crrev.com/7112189d9a2fdcb0e0cfe7ff618d30aebadbb59b/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/7112189d9a2fdcb0e0cfe7ff618d30aebadbb59b/ash/display/screen_orientation_controller_chromeos.cc
[modify] https://crrev.com/7112189d9a2fdcb0e0cfe7ff618d30aebadbb59b/ash/display/screen_orientation_controller_chromeos.h
[modify] https://crrev.com/7112189d9a2fdcb0e0cfe7ff618d30aebadbb59b/ash/test/screen_orientation_controller_test_api.cc
[modify] https://crrev.com/7112189d9a2fdcb0e0cfe7ff618d30aebadbb59b/ash/test/screen_orientation_controller_test_api.h
[modify] https://crrev.com/7112189d9a2fdcb0e0cfe7ff618d30aebadbb59b/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/7112189d9a2fdcb0e0cfe7ff618d30aebadbb59b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Status: Fixed (was: Started)
oshima@ Trying to verify this bug. Could you provide verification steps?

Comment 8 by osh...@chromium.org, May 12 2017

It's for ARC bug and must have been verified on ARC side.

I should've put the arc bug, but I couldn't find arc side bug, sorry.
Status: Verified (was: Fixed)

Sign in to add a comment