Unprefix the "grab" and "grabbing" CSS cursor values
Reported by
jon.rim...@logicalglue.com,
Apr 4 2017
|
|||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36 Steps to reproduce the problem: 1. Try to use the unprefixed versions of the "grab" and "grabbing" CSS cursors. What is the expected behavior? They should work. What went wrong? Only the -webkit- prefixed version works. Did this work before? N/A Does this work in other browsers? No Webkit and Gecko-based browsers also have these prefixed. Edge and IE Chrome version: 57.0.2987.133 Channel: stable OS Version: OS X 10.12.4 Flash Version: Shockwave Flash 25.0 r0 These property values have cross-browser support[1], they are part of a candidate recommendation[2], and they have been supported in Chrome for a long time. Keeping them prefixed only imposes a tax on developers writing interoperable code. [1] https://developer.mozilla.org/en/docs/Web/CSS/cursor#Browser_compatibility [2] https://www.w3.org/TR/css-ui-3/#cursor
,
Apr 4 2017
,
Apr 13 2017
These values have now been unprefixed in WebKit[1], leaving Blink as the only engine with them prefixed. [1] https://bugs.webkit.org/show_bug.cgi?id=170543
,
Jun 28 2017
Chrome currently fail the following tests of the CSSWG / Web-Platform-tests because of this: https://test.csswg.org/harness/test/css-ui-3_dev/single/cursor-009/format/html5/ https://test.csswg.org/harness/test/css-ui-3_dev/single/cursor-010/format/html5/
,
Aug 23 2017
Applies to operating systems other than Mac as well.
,
Oct 31 2017
Issue 676803 has been merged into this issue.
,
Oct 31 2017
,
Oct 31 2017
,
Oct 31 2017
,
Oct 31 2017
,
Dec 6 2017
,
Apr 11 2018
,
Apr 13 2018
i will take this issue.
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e6e3e4d8585ff4f662c3ad3ab163c0fb8cb0099 commit 1e6e3e4d8585ff4f662c3ad3ab163c0fb8cb0099 Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Fri Apr 13 08:42:24 2018 Add use counter for cursor with prefixed grab and grabbing value unprefixed versions of the "grab" and "grabbing" CSS cursors were not supported at blink. so we should check how many use prefixed values before retire that values. and i will make another patch to support unprefixed values parallelly. Bug: 708197 Change-Id: Ic882d9d6d5bc18724f3802c8ab2336668074f17d Reviewed-on: https://chromium-review.googlesource.com/1011883 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#550549} [modify] https://crrev.com/1e6e3e4d8585ff4f662c3ad3ab163c0fb8cb0099/third_party/blink/public/platform/web_feature.mojom [modify] https://crrev.com/1e6e3e4d8585ff4f662c3ad3ab163c0fb8cb0099/third_party/blink/renderer/core/css/properties/longhands/cursor_custom.cc [modify] https://crrev.com/1e6e3e4d8585ff4f662c3ad3ab163c0fb8cb0099/tools/metrics/histograms/enums.xml
,
Apr 16 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e6e3e4d8585ff4f662c3ad3ab163c0fb8cb0099 commit 1e6e3e4d8585ff4f662c3ad3ab163c0fb8cb0099 Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Fri Apr 13 08:42:24 2018 Add use counter for cursor with prefixed grab and grabbing value unprefixed versions of the "grab" and "grabbing" CSS cursors were not supported at blink. so we should check how many use prefixed values before retire that values. and i will make another patch to support unprefixed values parallelly. Bug: 708197 Change-Id: Ic882d9d6d5bc18724f3802c8ab2336668074f17d Reviewed-on: https://chromium-review.googlesource.com/1011883 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#550549} [modify] https://crrev.com/1e6e3e4d8585ff4f662c3ad3ab163c0fb8cb0099/third_party/blink/public/platform/web_feature.mojom [modify] https://crrev.com/1e6e3e4d8585ff4f662c3ad3ab163c0fb8cb0099/third_party/blink/renderer/core/css/properties/longhands/cursor_custom.cc [modify] https://crrev.com/1e6e3e4d8585ff4f662c3ad3ab163c0fb8cb0099/tools/metrics/histograms/enums.xml
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f35aeeb0b034109a6a0be51309ab7189b568f8b6 commit f35aeeb0b034109a6a0be51309ab7189b568f8b6 Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Wed Apr 25 22:22:05 2018 Support grab and grabbing values for cursor property unprefixed versions of the "grab" and "grabbing" CSS cursors were not supported at blink. Bug: 708197 Change-Id: I4d4b7e61884bc565526fb92374e40c9dc7ec36a6 Reviewed-on: https://chromium-review.googlesource.com/1012047 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#553791} [delete] https://crrev.com/7c13f644750fbb199287becfb2ca7415121aa3d4/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/cursor-expected.txt [modify] https://crrev.com/f35aeeb0b034109a6a0be51309ab7189b568f8b6/third_party/WebKit/LayoutTests/fast/css/cursor-parsing-expected.txt [modify] https://crrev.com/f35aeeb0b034109a6a0be51309ab7189b568f8b6/third_party/WebKit/LayoutTests/fast/css/cursor-parsing.html [modify] https://crrev.com/f35aeeb0b034109a6a0be51309ab7189b568f8b6/third_party/WebKit/LayoutTests/fast/events/mouse-cursor-expected.txt [modify] https://crrev.com/f35aeeb0b034109a6a0be51309ab7189b568f8b6/third_party/WebKit/LayoutTests/fast/events/mouse-cursor.html [modify] https://crrev.com/f35aeeb0b034109a6a0be51309ab7189b568f8b6/third_party/blink/renderer/core/css/CSSProperties.json5 [modify] https://crrev.com/f35aeeb0b034109a6a0be51309ab7189b568f8b6/third_party/blink/renderer/core/css/CSSValueKeywords.json5 [modify] https://crrev.com/f35aeeb0b034109a6a0be51309ab7189b568f8b6/third_party/blink/renderer/core/css/css_value_id_mappings.h [modify] https://crrev.com/f35aeeb0b034109a6a0be51309ab7189b568f8b6/third_party/blink/renderer/core/input/event_handler.cc
,
May 8 2018
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by nainar@chromium.org
, Apr 4 2017Status: Available (was: Unconfirmed)