New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708195 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 674593


Show other hotlists

Hotlists containing this issue:
Non-Standard-IDL


Sign in to add a comment

Rename CanvasPathMethods to CanvasPath (spec sync, non-observable change)

Project Member Reported by foolip@chromium.org, Apr 4 2017

Issue description

https://html.spec.whatwg.org/multipage/scripting.html#canvaspath

This mixin is called CanvasPathMethods. Naming it as in the spec will make the job of Web IDL diff tooling slightly easier.
 

Comment 1 by junov@chromium.org, Apr 5 2017

Owner: fs...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e51782890830ad8e709199ad65ce66e52af90441

commit e51782890830ad8e709199ad65ce66e52af90441
Author: fserb <fserb@chromium.org>
Date: Wed Apr 19 19:17:59 2017

Rename CanvasPathMethods to CanvasPath

The spec calls this CanvasPath. Renaming to sync with spec.

BUG= 708195 

Review-Url: https://codereview.chromium.org/2826773002
Cr-Commit-Position: refs/heads/master@{#465699}

[modify] https://crrev.com/e51782890830ad8e709199ad65ce66e52af90441/third_party/WebKit/LayoutTests/fast/canvas/canvas-arc-negative-radius.html
[modify] https://crrev.com/e51782890830ad8e709199ad65ce66e52af90441/third_party/WebKit/LayoutTests/fast/canvas/canvas-ellipse-negative-radius.html
[modify] https://crrev.com/e51782890830ad8e709199ad65ce66e52af90441/third_party/WebKit/Source/modules/canvas2d/BUILD.gn
[modify] https://crrev.com/e51782890830ad8e709199ad65ce66e52af90441/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
[rename] https://crrev.com/e51782890830ad8e709199ad65ce66e52af90441/third_party/WebKit/Source/modules/canvas2d/CanvasPath.cpp
[rename] https://crrev.com/e51782890830ad8e709199ad65ce66e52af90441/third_party/WebKit/Source/modules/canvas2d/CanvasPath.h
[rename] https://crrev.com/e51782890830ad8e709199ad65ce66e52af90441/third_party/WebKit/Source/modules/canvas2d/CanvasPath.idl
[modify] https://crrev.com/e51782890830ad8e709199ad65ce66e52af90441/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl
[modify] https://crrev.com/e51782890830ad8e709199ad65ce66e52af90441/third_party/WebKit/Source/modules/canvas2d/Path2D.h
[modify] https://crrev.com/e51782890830ad8e709199ad65ce66e52af90441/third_party/WebKit/Source/modules/canvas2d/Path2D.idl
[modify] https://crrev.com/e51782890830ad8e709199ad65ce66e52af90441/third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.idl
[modify] https://crrev.com/e51782890830ad8e709199ad65ce66e52af90441/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/e51782890830ad8e709199ad65ce66e52af90441/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl
[modify] https://crrev.com/e51782890830ad8e709199ad65ce66e52af90441/third_party/WebKit/Source/platform/graphics/Path.cpp
[modify] https://crrev.com/e51782890830ad8e709199ad65ce66e52af90441/third_party/WebKit/Source/platform/graphics/Path.h

Comment 3 by fs...@chromium.org, Apr 19 2017

Status: Fixed (was: Assigned)
donerino. :)

Comment 4 by foolip@chromium.org, Apr 20 2017

Thanks :)

Sign in to add a comment