ClangToTWin failing with -Wsign-compare |
||
Issue descriptionFrom https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/11843: FAILED: obj/chrome/installer/util/installer_util_unittests/l10n_string_util_unittest.obj ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/chrome/installer/util/installer_util_unittests/l10n_string_util_unittest.obj.rsp /c ../../chrome/installer/util/l10n_string_util_unittest.cc /Foobj/chrome/installer/util/installer_util_unittests/l10n_string_util_unittest.obj /Fd"obj/chrome/installer/util/installer_util_unittests_cc.pdb" In file included from ../../chrome/installer/util/l10n_string_util_unittest.cc:11: C:\b\c\b\ClangToTWin\src\testing\gtest\include\gtest\gtest.h(1392,16): error: comparison of integers of different signs: 'const int' and 'const unsigned int' [-Werror,-Wsign-compare] if (expected == actual) { ~~~~~~~~ ^ ~~~~~~ Probably a test that doesn't get built on many other bots? This is probably the culprit: https://codereview.chromium.org/2791593002
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77b4b28f7866f526a13426dd5c5ca2e8f0156c7a commit 77b4b28f7866f526a13426dd5c5ca2e8f0156c7a Author: hans <hans@chromium.org> Date: Tue Apr 04 16:27:57 2017 Fix -Wsign-compare in l10n_string_util_unittest.cc Clang builds were failing with: C:\b\c\b\ClangToTWin\src\testing\gtest\include\gtest\gtest.h(1392,16): error: comparison of integers of different signs: 'const int' and 'const unsigned int' [-Werror,-Wsign-compare] if (expected == actual) { ~~~~~~~~ ^ ~~~~~~ BUG= 708178 TBR=grt Review-Url: https://codereview.chromium.org/2794183004 Cr-Commit-Position: refs/heads/master@{#461742} [modify] https://crrev.com/77b4b28f7866f526a13426dd5c5ca2e8f0156c7a/chrome/installer/util/l10n_string_util_unittest.cc
,
Apr 4 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by h...@chromium.org
, Apr 4 2017Status: Started (was: Available)