Issue metadata
Sign in to add a comment
|
OMA DRM files are not downloaded to the Download directory |
||||||||||||||||||||
Issue descriptionDownload any OMA DRM files, and the file will be downloaded to an internal shared volume, which is not publicly accessible. The issue is that we are using Android DownloadManager to generate the download path, as it will rename the file from foo.dm to foo.fl. However, the default path Android DM uses is not the Download directory. So we have to provide our own path to the Android DM.
,
Apr 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b226550dbd1834c2f7addec9d1df7d57498fb7fc commit b226550dbd1834c2f7addec9d1df7d57498fb7fc Author: qinmin <qinmin@chromium.org> Date: Tue Apr 04 23:59:56 2017 Pass file name when downloading OMA DRM files When downloading a OMA DRM file, currently we use Android DownloadManager to generate the file path. This is because the Android DM may rename the file. However, the Android DownloadManager will by default save the file to an internal directory, which cannot be accessed by other apps. This CL passes the file name from native to Android DownloadManager. So the file path generation will be determined by Chrome. This change also fixes the problem of openning a DRM download from snackbar. Instead of openning download home, this CL will open the Downloads app instead. BUG= 708172 Review-Url: https://codereview.chromium.org/2797003002 Cr-Commit-Position: refs/heads/master@{#461906} [modify] https://crrev.com/b226550dbd1834c2f7addec9d1df7d57498fb7fc/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java [modify] https://crrev.com/b226550dbd1834c2f7addec9d1df7d57498fb7fc/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java [modify] https://crrev.com/b226550dbd1834c2f7addec9d1df7d57498fb7fc/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java [modify] https://crrev.com/b226550dbd1834c2f7addec9d1df7d57498fb7fc/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java [modify] https://crrev.com/b226550dbd1834c2f7addec9d1df7d57498fb7fc/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java [modify] https://crrev.com/b226550dbd1834c2f7addec9d1df7d57498fb7fc/chrome/browser/android/download/chrome_download_delegate.cc [modify] https://crrev.com/b226550dbd1834c2f7addec9d1df7d57498fb7fc/chrome/browser/android/download/chrome_download_delegate.h [modify] https://crrev.com/b226550dbd1834c2f7addec9d1df7d57498fb7fc/chrome/browser/android/download/download_controller.cc
,
Apr 5 2017
,
Apr 5 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/491c64631059a22f1d11a8d18985427159553a6e commit 491c64631059a22f1d11a8d18985427159553a6e Author: Min Qin <qinmin@chromium.org> Date: Wed Apr 05 17:15:00 2017 Pass file name when downloading OMA DRM files When downloading a OMA DRM file, currently we use Android DownloadManager to generate the file path. This is because the Android DM may rename the file. However, the Android DownloadManager will by default save the file to an internal directory, which cannot be accessed by other apps. This CL passes the file name from native to Android DownloadManager. So the file path generation will be determined by Chrome. This change also fixes the problem of openning a DRM download from snackbar. Instead of openning download home, this CL will open the Downloads app instead. BUG= 708172 TBR=dtrainor@chromium.org Review-Url: https://codereview.chromium.org/2797003002 Cr-Commit-Position: refs/heads/master@{#461906} (cherry picked from commit b226550dbd1834c2f7addec9d1df7d57498fb7fc) Review-Url: https://codereview.chromium.org/2801793002 . Cr-Commit-Position: refs/branch-heads/3029@{#589} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/491c64631059a22f1d11a8d18985427159553a6e/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java [modify] https://crrev.com/491c64631059a22f1d11a8d18985427159553a6e/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java [modify] https://crrev.com/491c64631059a22f1d11a8d18985427159553a6e/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java [modify] https://crrev.com/491c64631059a22f1d11a8d18985427159553a6e/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java [modify] https://crrev.com/491c64631059a22f1d11a8d18985427159553a6e/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java [modify] https://crrev.com/491c64631059a22f1d11a8d18985427159553a6e/chrome/browser/android/download/chrome_download_delegate.cc [modify] https://crrev.com/491c64631059a22f1d11a8d18985427159553a6e/chrome/browser/android/download/chrome_download_delegate.h [modify] https://crrev.com/491c64631059a22f1d11a8d18985427159553a6e/chrome/browser/android/download/download_controller.cc
,
Apr 5 2017
,
May 24 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by qin...@chromium.org
, Apr 4 2017