New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708162 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add additional metrics for subresource filtering

Project Member Reported by bmcquade@chromium.org, Apr 4 2017

Issue description

We should add the following:
* parse blocking script breakouts, so we can better understand differences in
  improvements to FCP/FMP due to doc.write blocking vs general subresource
  filtering
* foreground duration, so we can understand time on page when subresource
  filtering is active
* byte and resource counts for pages where media was played
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4244d4e4d0a4dc0e6fd0eea57801dfbf41401600

commit 4244d4e4d0a4dc0e6fd0eea57801dfbf41401600
Author: bmcquade <bmcquade@chromium.org>
Date: Wed Apr 05 23:52:46 2017

Add additional metrics for subresource filtering.

This change adds the following:
* parse blocking script breakouts, so we can better understand differences in
  improvements to FCP/FMP due to doc.write blocking vs general subresource
  filtering
* foreground duration, so we can understand time on page when subresource
  filtering is active
* byte and resource counts for pages where media was played

BUG= 708162 

Review-Url: https://codereview.chromium.org/2795453003
Cr-Commit-Position: refs/heads/master@{#462278}

[modify] https://crrev.com/4244d4e4d0a4dc0e6fd0eea57801dfbf41401600/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc
[modify] https://crrev.com/4244d4e4d0a4dc0e6fd0eea57801dfbf41401600/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h
[modify] https://crrev.com/4244d4e4d0a4dc0e6fd0eea57801dfbf41401600/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
[modify] https://crrev.com/4244d4e4d0a4dc0e6fd0eea57801dfbf41401600/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment