PrerenderBrowserTest failing on chromium.memory/Mac ASan 64 Tests (1) |
|||||||||
Issue descriptionPrerenderBrowserTest.PrerenderPageNavigateFragment, PrerenderBrowserTest.PrerenderExtraHeadersNoSwap and PrerenderBrowserTest.PrerenderFragmentNavigatePage: https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/28684 and several more on https://build.chromium.org/p/chromium.memory/waterfall?show=Mac%20ASan%2064%20Tests%20(1). Pasko: Could you take a look?
,
Apr 4 2017
,
Apr 4 2017
looks specific to macos+asan: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=PrerenderBrowserTest.PrerenderFragmentNavigatePage not sure how long ago it started failing, the flakiness dashboard shows me only a few days. The error suggests that it's because the combination of clientredirects+mac+asan is too slow: ../../chrome/browser/prerender/prerender_test_utils.cc:350: Failure Value of: final_status() Actual: 1 Expected: expected_final_status_ Which is: 7 when testing URL /client-redirect (Expected: App Terminating, Actual: Timed Out) Is there a way to increase timeout for a specific browser test?
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c553fcf813fdfeaa5e94e01daa2cad2c7b71a6b3 commit c553fcf813fdfeaa5e94e01daa2cad2c7b71a6b3 Author: maxmorin <maxmorin@chromium.org> Date: Tue Apr 04 16:44:30 2017 Disable flaky PrerenderBrowserTests on Mac/asan. TBR=pasko@chromium.org BUG=708158 Review-Url: https://codereview.chromium.org/2790273003 Cr-Commit-Position: refs/heads/master@{#461747} [modify] https://crrev.com/c553fcf813fdfeaa5e94e01daa2cad2c7b71a6b3/chrome/browser/prerender/prerender_browsertest.cc
,
Apr 5 2017
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2dc6e6c586fec4172d039ede8927d81d2caa9d6a commit 2dc6e6c586fec4172d039ede8927d81d2caa9d6a Author: ellyjones <ellyjones@chromium.org> Date: Thu Apr 06 13:03:34 2017 prerender: disable flaky PrerenderFragmentNavigateFragment on mac asan This test was missed while disabling others for this bug. BUG=708158 TBR=pasko@chromium.org Review-Url: https://codereview.chromium.org/2803623005 Cr-Commit-Position: refs/heads/master@{#462442} [modify] https://crrev.com/2dc6e6c586fec4172d039ede8927d81d2caa9d6a/chrome/browser/prerender/prerender_browsertest.cc
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9773c2d02cb96b2a980dfd5844927a2ca2fd328 commit c9773c2d02cb96b2a980dfd5844927a2ca2fd328 Author: ellyjones <ellyjones@chromium.org> Date: Thu Apr 06 15:30:01 2017 prerender: disable NocommitNoSwap tests These are flaky under mac ASAN. BUG=708158 TBR=pasko@chromium.org Review-Url: https://codereview.chromium.org/2804023002 Cr-Commit-Position: refs/heads/master@{#462482} [modify] https://crrev.com/c9773c2d02cb96b2a980dfd5844927a2ca2fd328/chrome/browser/prerender/prerender_browsertest.cc
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9f2dc22030cf8d465a6c6e31d94b53b581463c1 commit d9f2dc22030cf8d465a6c6e31d94b53b581463c1 Author: ellyjones <ellyjones@chromium.org> Date: Thu Apr 06 17:21:26 2017 prerender: disable all browser tests on mac asan All of these tests seem flaky on mac asan. BUG=708158 TBR=pasko@chromium.org Review-Url: https://codereview.chromium.org/2798273003 Cr-Commit-Position: refs/heads/master@{#462525} [modify] https://crrev.com/d9f2dc22030cf8d465a6c6e31d94b53b581463c1/chrome/browser/prerender/prerender_browsertest.cc
,
Apr 10 2017
,
Jan 9 2018
Why is this marked fixed? The test is still disabled.
,
Jan 9 2018
,
Jan 9 2018
sry, operator error.
,
Jan 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4ca33fbd5e0e972583787edcb3190dc953aa1a2 commit f4ca33fbd5e0e972583787edcb3190dc953aa1a2 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Tue Jan 09 18:11:11 2018 Disable PrerenderBrowserTest.MAYBE_PrerenderNoCommitNoSwap on Linux dbg TBR=pasko@chromium.org Bug: 800373 ,708158 Change-Id: Ifa2e13b823161bc4fee015e7ea46d44568b36098 Reviewed-on: https://chromium-review.googlesource.com/857579 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#528046} [modify] https://crrev.com/f4ca33fbd5e0e972583787edcb3190dc953aa1a2/chrome/browser/prerender/prerender_browsertest.cc
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e8e835a39287fceb827495ce7edd144df89030c commit 9e8e835a39287fceb827495ce7edd144df89030c Author: Egor Pasko <pasko@chromium.org> Date: Tue Jan 23 10:42:40 2018 prerender: increase timeout for Asan Generally ASAN-instrumented builds run slower and hit various timeouts in tests, so we scale the test timeouts for it. We have not been scaling timeouts for PrerenderContents lifetime. The bug below lists at least one failure due to this issue, other logs/evidence is not easy to get. This patch changes two things: 1. Increases PrerenderContents lifetime 2x when running with ASAN 2. Re-enables all tests under ASAN to start collecting new flake The change (1) may cause more memory consumption to those rare users who force prerender=ON with about:flags in those occasional Dev/Canary builds that ship with ASAN enabled. This situation seems rare and not worth plumbing testing overrides around prerender_config. Bug: 708158 Change-Id: I8df6e54f5dac1247f6bff1125a8bfd77d51bcc7b Reviewed-on: https://chromium-review.googlesource.com/878802 Reviewed-by: Matthew Cary <mattcary@chromium.org> Reviewed-by: Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#531201} [modify] https://crrev.com/9e8e835a39287fceb827495ce7edd144df89030c/chrome/browser/prerender/prerender_browsertest.cc [modify] https://crrev.com/9e8e835a39287fceb827495ce7edd144df89030c/chrome/browser/prerender/prerender_config.cc
,
Jan 23 2018
last change made PrerenderClientRedirectToFragment flaky on MacOS ASAN: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FMac_ASan_64_Tests__1_%2F38064%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FPrerenderBrowserTest.PrerenderClientRedirectToFragment%2F0 [ RUN ] PrerenderBrowserTest.PrerenderClientRedirectToFragment [30964:55555:0123/053253.833142:WARNING:mac_util.mm(226)] Failed to set backup exclusion for file '/private/var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.2bDlH2/d11zgw4/Default/History': Error Domain=NSOSStatusErrorDomain Code=-50 "The operation couldn?t be completed. (OSStatus error -50.)" (paramErr: error in user parameter list) (-50) [30964:2823:0123/053253.858925:WARNING:notification_platform_bridge_mac.mm(510)] AlertNotificationService: XPC connection invalidated. [30969:3335:0123/053254.131987:WARNING:vt_video_decode_accelerator_mac.cc(177)] Failed to create VTDecompressionSession: Error Domain=NSOSStatusErrorDomain Code=-8973 "The operation couldn?t be completed. (OSStatus error -8973.)" (codecOpenErr) (-8973) [30969:3335:0123/053254.133764:WARNING:vt_video_decode_accelerator_mac.cc(199)] Failed to create hardware VideoToolbox session [30969:3335:0123/053254.223039:ERROR:vt_video_encode_accelerator_mac.cc(517)] VTCompressionSessionCreate failed: -12908 [30964:55555:0123/053254.604878:WARNING:mac_util.mm(226)] Failed to set backup exclusion for file '/private/var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.2bDlH2/d11zgw4/Default/Favicons': Error Domain=NSOSStatusErrorDomain Code=-50 "The operation couldn?t be completed. (OSStatus error -50.)" (paramErr: error in user parameter list) (-50) [30964:38147:0123/053254.978702:WARNING:simple_synchronous_entry.cc(1173)] Could not open platform files for entry. [30964:43783:0123/053255.082061:ERROR:test_database_manager.cc(64)] Not implemented reached in virtual bool safe_browsing::TestSafeBrowsingDatabaseManager::CheckResourceUrl(const GURL &, safe_browsing::SafeBrowsingDatabaseManager::Client *) [30964:97539:0123/053255.170870:WARNING:embedded_test_server.cc(228)] Request not handled. Returning 404: /favicon.ico ../../chrome/browser/prerender/prerender_test_utils.cc:355: Failure Expected equality of these values: expected_final_status_ Which is: 7 final_status() Which is: 1 when testing URL /client-redirect (Expected: App Terminating, Actual: Timed Out)
,
Jan 23 2018
It seems to be timing out after a minute at most which is strange given your CL.
,
Jan 23 2018
Yeah, those seem to be seconds, not minutes. It is certainly not fixed by my change. Extending the dashboard to all PrerenderBrowserTest on that bot the flake comes from these 8 tests: PrerenderBrowserTest.HttpPost PrerenderBrowserTest.PrerenderBrowserInitiatedPostNoSwap PrerenderBrowserTest.PrerenderClientRedirectFromFragment PrerenderBrowserTest.PrerenderClientRedirectToFragment PrerenderBrowserTest.PrerenderExtraHeadersNoSwap PrerenderBrowserTest.PrerenderFragmentNavigateFragment PrerenderBrowserTest.PrerenderFragmentNavigatePage PrerenderBrowserTest.PrerenderNoCommitNoSwap2 PrerenderBrowserTest.PrerenderPageNavigateFragment The common theme for these is to expect FINAL_STATUS_APP_TERMINATING and get FINAL_STATUS_TIMED_OUT instead. I don't have good theories on why this could happen with MacASAN specifically, does it advance the clock on shutdown? +glider
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/531fac6a162204fb3523f2ad38068c95d3224b2e commit 531fac6a162204fb3523f2ad38068c95d3224b2e Author: Egor Pasko <pasko@chromium.org> Date: Tue Jan 23 19:01:45 2018 prerender: disable browser_tests on MacASAN Also revert the time scaling, since the timeouts happen faster than the scaled time goes. Not doing a revert to eliminate some duplication of disabling that we had previously. TBR=mattcary@chromium.org Bug: 708158 Change-Id: I367e4bd3c5e309a3f72078e7cd165e7d1182f257 Reviewed-on: https://chromium-review.googlesource.com/881184 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#531292} [modify] https://crrev.com/531fac6a162204fb3523f2ad38068c95d3224b2e/chrome/browser/prerender/prerender_browsertest.cc [modify] https://crrev.com/531fac6a162204fb3523f2ad38068c95d3224b2e/chrome/browser/prerender/prerender_config.cc |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by maxmorin@chromium.org
, Apr 4 2017