New issue
Advanced search Search tips

Issue 708151 link

Starred by 1 user
Status: Fixed
Owner:
rohitrao@chromium.org
Closed: Apr 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocking:
issue 708341



Sign in to add a comment

Rename LocationBarViewIOS to LocationBarController

Project Member Reported by rohitrao@chromium.org, Apr 4 2017 
This class acts as a controller, not as a view, so it should be renamed to match its function.

Also split out a LocationBarController interface that is separate from the LocationBarControllerImpl implementation, to make it possible to create a fake for unittests.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd324eb7d820806adc5a2830c613d0976ebb73ad

commit cd324eb7d820806adc5a2830c613d0976ebb73ad
Author: rohitrao <rohitrao@chromium.org>
Date: Tue Apr 04 15:36:39 2017

[ios] Adds a LocationBarController interface.

Renames the existing LocationBarViewIOS class to LocationBarControllerImpl.
Moves files into ios/shared.

BUG= 708151 

Review-Url: https://codereview.chromium.org/2796793003
Cr-Commit-Position: refs/heads/master@{#461729}

[modify] https://crrev.com/cd324eb7d820806adc5a2830c613d0976ebb73ad/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/cd324eb7d820806adc5a2830c613d0976ebb73ad/ios/chrome/browser/ui/omnibox/BUILD.gn
[modify] https://crrev.com/cd324eb7d820806adc5a2830c613d0976ebb73ad/ios/chrome/browser/ui/omnibox/chrome_omnibox_client_ios.mm
[add] https://crrev.com/cd324eb7d820806adc5a2830c613d0976ebb73ad/ios/chrome/browser/ui/omnibox/location_bar_controller_impl.h
[rename] https://crrev.com/cd324eb7d820806adc5a2830c613d0976ebb73ad/ios/chrome/browser/ui/omnibox/location_bar_controller_impl.mm
[delete] https://crrev.com/1de903938832ed377f635aa4475639b8ca40ceb6/ios/chrome/browser/ui/omnibox/location_bar_view_ios.h
[modify] https://crrev.com/cd324eb7d820806adc5a2830c613d0976ebb73ad/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm
[modify] https://crrev.com/cd324eb7d820806adc5a2830c613d0976ebb73ad/ios/chrome/browser/ui/omnibox_perftest.mm
[modify] https://crrev.com/cd324eb7d820806adc5a2830c613d0976ebb73ad/ios/chrome/browser/ui/qr_scanner/BUILD.gn
[modify] https://crrev.com/cd324eb7d820806adc5a2830c613d0976ebb73ad/ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm
[modify] https://crrev.com/cd324eb7d820806adc5a2830c613d0976ebb73ad/ios/chrome/browser/ui/toolbar/BUILD.gn
[modify] https://crrev.com/cd324eb7d820806adc5a2830c613d0976ebb73ad/ios/chrome/browser/ui/toolbar/web_toolbar_controller.h
[modify] https://crrev.com/cd324eb7d820806adc5a2830c613d0976ebb73ad/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
[modify] https://crrev.com/cd324eb7d820806adc5a2830c613d0976ebb73ad/ios/chrome/browser/ui/toolbar/web_toolbar_controller_private.h
[modify] https://crrev.com/cd324eb7d820806adc5a2830c613d0976ebb73ad/ios/shared/chrome/browser/ui/DEPS
[add] https://crrev.com/cd324eb7d820806adc5a2830c613d0976ebb73ad/ios/shared/chrome/browser/ui/omnibox/BUILD.gn
[add] https://crrev.com/cd324eb7d820806adc5a2830c613d0976ebb73ad/ios/shared/chrome/browser/ui/omnibox/location_bar_controller.cc
[add] https://crrev.com/cd324eb7d820806adc5a2830c613d0976ebb73ad/ios/shared/chrome/browser/ui/omnibox/location_bar_controller.h
[add] https://crrev.com/cd324eb7d820806adc5a2830c613d0976ebb73ad/ios/shared/chrome/browser/ui/omnibox/location_bar_delegate.h
[rename] https://crrev.com/cd324eb7d820806adc5a2830c613d0976ebb73ad/ios/shared/chrome/browser/ui/omnibox/web_omnibox_edit_controller.cc
[rename] https://crrev.com/cd324eb7d820806adc5a2830c613d0976ebb73ad/ios/shared/chrome/browser/ui/omnibox/web_omnibox_edit_controller.h

Comment 2 by rohitrao@chromium.org, Apr 4 2017

Blocking: 708341

Comment 3 by rohitrao@chromium.org, Apr 18 2017

Status: Fixed (was: Started)
►

Sign in to add a comment