New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708143 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Security

Blocking:
issue 524919



Sign in to add a comment

[qcms] Fix overflow when reading parametric gamma curves

Project Member Reported by noel@chromium.org, Apr 4 2017

Issue description

Reported on b/35485930, and fix submitted. Backport into QCMS.

 

Comment 1 by noel@chromium.org, Apr 4 2017

Cc: hubbe@chromium.org
Owner: noel@chromium.org
Status: Started (was: Untriaged)
https://codereview.chromium.org/2796893002/

Comment 2 by noel@chromium.org, Apr 4 2017

Blocking: 524919
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0eb3418b597de14bff675fde0e575fbc947ff962

commit 0eb3418b597de14bff675fde0e575fbc947ff962
Author: noel <noel@chromium.org>
Date: Wed Apr 05 02:37:20 2017

[qcms] Fix overflow when reading parametric gamma curves

The ICC spec does not impose input restrictions to compute a parametric
curve LUT. The largest value computed can reach about pow(65536,32768).
To prevent explicit handling of a large double, use powf(), and prevent
precision loss by executing right-to-left.

BUG= 708143 

Review-Url: https://codereview.chromium.org/2796893002
Cr-Commit-Position: refs/heads/master@{#461947}

[modify] https://crrev.com/0eb3418b597de14bff675fde0e575fbc947ff962/third_party/qcms/README.chromium
[modify] https://crrev.com/0eb3418b597de14bff675fde0e575fbc947ff962/third_party/qcms/src/transform_util.c

Comment 4 by noel@chromium.org, Apr 5 2017

Status: Fixed (was: Started)
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 5 2017

Labels: Restrict-View-SecurityNotify
Labels: Security_Severity-Medium Security_Impact-Stable M-59
Labels: Release-0-M59
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 12 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by sheriffbot@chromium.org, Jul 28

Labels: -Pri-3 Pri-1

Sign in to add a comment