WebNavigationApiTest.CrossProcessHistory is flaky. |
||||
Issue descriptionSee e.g. https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/10052 and https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_side_navigation_browser_tests&showExpectations=true&tests=WebNavigationApiTest.CrossProcessHistory. Nasko: Could you take a look?
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/daf2c25d72ad3db6bcf3ea3576ae6d0985fffa64 commit daf2c25d72ad3db6bcf3ea3576ae6d0985fffa64 Author: maxmorin <maxmorin@chromium.org> Date: Tue Apr 04 14:45:22 2017 Disable flaky WebNavigationApiTest.CrossProcessFragment. Also flaky: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/62126. TBR=nasko@chromium.org BUG= 708139 Review-Url: https://codereview.chromium.org/2795863004 Cr-Commit-Position: refs/heads/master@{#461710} [modify] https://crrev.com/daf2c25d72ad3db6bcf3ea3576ae6d0985fffa64/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
,
Apr 4 2017
maxmorin@ - did you investigate whether any changes were made around the time of the flakiness start that could impact this? Just disabling the test is useful to allow bots to be more consistent, but it also runs the risk of losing track of what could've caused this flakiness to start, especially as the logs might disappear.
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d1a7f6758769bb73a40ff8b8d21aa3b580a4926 commit 6d1a7f6758769bb73a40ff8b8d21aa3b580a4926 Author: nasko <nasko@chromium.org> Date: Tue Apr 04 18:14:35 2017 Disable CrossProcessHistory and CrossProcessFragment with PlzNavigate. These two tests were fully disabled due to flakiness. However, they only flake with PlzNavigate enabled, so this CL enables them with the current navigation code. BUG= 708139 Review-Url: https://codereview.chromium.org/2797753002 Cr-Commit-Position: refs/heads/master@{#461769} [modify] https://crrev.com/6d1a7f6758769bb73a40ff8b8d21aa3b580a4926/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
,
Apr 5 2017
I agree that the culprit should be reverted rather than disabling the test if possible. I disabled the test as I didn't see any suspicious CL.
,
Apr 6 2017
It appears flaky without PlzNavigate as well: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/builds/54421 I am reverting https://codereview.chromium.org/2797753002 for now.
,
Apr 6 2017
BrowserTestBase received signal: Terminated. Backtrace: #0 0x0000028f5f57 base::debug::StackTrace::StackTrace() #1 0x000002e5c316 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f20ed68bcb0 <unknown> #3 0x7f20ed74584d __poll #4 0x7f20f31b8fe4 <unknown> #5 0x7f20f31b90ec g_main_context_iteration #6 0x00000290f9c6 base::MessagePumpGlib::Run() #7 0x00000290dbe7 base::MessageLoop::RunHandler() #8 0x00000292c60e base::RunLoop::Run() #9 0x000002e82c2e content::RunThisRunLoop() #10 0x000005f9c0bf extensions::ResultCatcher::GetNextResult() #11 0x0000012bf3dc ExtensionApiTest::RunExtensionTestImpl() #12 0x0000012bf178 ExtensionApiTest::RunExtensionTest() #13 0x0000009cb55c extensions::WebNavigationApiTest_CrossProcessHistory_Test::RunTestOnMainThread() #14 0x0000029a10df InProcessBrowserTest::RunTestOnMainThreadLoop() #15 0x000002e5c078 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #16 0x000002cccb24 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #17 0x000002ccbbcb ChromeBrowserMainParts::PreMainMessageLoopRun() #18 0x00000197068f content::BrowserMainLoop::PreMainMessageLoopRun() #19 0x000001c36897 content::StartupTaskRunner::RunAllTasksNow() #20 0x00000196e945 content::BrowserMainLoop::CreateStartupTasks() #21 0x000001972f44 content::BrowserMainRunnerImpl::Initialize() #22 0x00000196c0a2 content::BrowserMain() #23 0x0000028e01bc content::ContentMainRunnerImpl::Run() #24 0x000003ead1ef service_manager::Main() #25 0x0000028df232 content::ContentMain() #26 0x000002e5b9b9 content::BrowserTestBase::SetUp() #27 0x00000299f7d0 InProcessBrowserTest::SetUp() #28 0x00000345f1de testing::Test::Run() #29 0x00000345fd50 testing::TestInfo::Run() #30 0x000003460277 testing::TestCase::Run() #31 0x0000034672b7 testing::internal::UnitTestImpl::RunAllTests() #32 0x000003466f37 testing::UnitTest::Run() #33 0x0000029b09c1 base::TestSuite::Run() #34 0x0000028ea9b8 ChromeTestSuiteRunner::RunTestSuite() #35 0x000002e7fb8a content::LaunchTests() #36 0x0000028ea937 main #37 0x7f20ed676f45 __libc_start_main #38 0x0000005fe8fd <unknown>
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17fc62872e411a7ab02f9f352763073e43d38916 commit 17fc62872e411a7ab02f9f352763073e43d38916 Author: ellyjones <ellyjones@chromium.org> Date: Thu Apr 06 13:59:36 2017 Revert of Disable CrossProcessHistory and CrossProcessFragment with PlzNavigate. (patchset #1 id:1 of https://codereview.chromium.org/2797753002/ ) Reason for revert: Test is flaky without PlzNavigate also: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/builds/54421 Original issue's description: > Disable CrossProcessHistory and CrossProcessFragment with PlzNavigate. > > These two tests were fully disabled due to flakiness. However, they > only flake with PlzNavigate enabled, so this CL enables them with the > current navigation code. > > BUG= 708139 > > Review-Url: https://codereview.chromium.org/2797753002 > Cr-Commit-Position: refs/heads/master@{#461769} > Committed: https://chromium.googlesource.com/chromium/src/+/6d1a7f6758769bb73a40ff8b8d21aa3b580a4926 TBR=alexmos@chromium.org,nasko@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 708139 Review-Url: https://codereview.chromium.org/2803013002 Cr-Commit-Position: refs/heads/master@{#462454} [modify] https://crrev.com/17fc62872e411a7ab02f9f352763073e43d38916/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ccdcc6ef79a614b1b1c87a78a883d9c5b19ffde2 commit ccdcc6ef79a614b1b1c87a78a883d9c5b19ffde2 Author: nasko <nasko@chromium.org> Date: Wed Apr 19 19:35:44 2017 Revert of Disable flaky WebNavigationApiTest.CrossProcessHistory. (patchset #1 id:1 of https://codereview.chromium.org/2790383002/ ) Reason for revert: What I believe was the underlying issue has been reverted, so it should be safe to reenable this test back. Original issue's description: > Disable flaky WebNavigationApiTest.CrossProcessHistory. > > TBR=nasko@chromium.org > BUG= 708139 > > Review-Url: https://codereview.chromium.org/2790383002 > Cr-Commit-Position: refs/heads/master@{#461690} > Committed: https://chromium.googlesource.com/chromium/src/+/656fccff69eae8da012f0f83bcd3fc89214c5258 TBR=maxmorin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 708139 Review-Url: https://codereview.chromium.org/2830813002 Cr-Commit-Position: refs/heads/master@{#465709} [modify] https://crrev.com/ccdcc6ef79a614b1b1c87a78a883d9c5b19ffde2/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
,
Apr 19 2017
,
Apr 19 2017
This flakiness has returned upon this revert. Revert, reverted.
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4be5c7090175b7410f2a9adcb447a111d152c94 commit a4be5c7090175b7410f2a9adcb447a111d152c94 Author: rogerm <rogerm@chromium.org> Date: Wed Apr 19 21:14:43 2017 Reland of Disable flaky WebNavigationApiTest.CrossProcessHistory. (patchset #1 id:1 of https://codereview.chromium.org/2830813002/ ) Reason for revert: The flakiness came back upon landing this revert. So, reverting the revert. Original issue's description: > Revert of Disable flaky WebNavigationApiTest.CrossProcessHistory. (patchset #1 id:1 of https://codereview.chromium.org/2790383002/ ) > > Reason for revert: > What I believe was the underlying issue has been reverted, so it should be safe to reenable this test back. > > Original issue's description: > > Disable flaky WebNavigationApiTest.CrossProcessHistory. > > > > TBR=nasko@chromium.org > > BUG= 708139 > > > > Review-Url: https://codereview.chromium.org/2790383002 > > Cr-Commit-Position: refs/heads/master@{#461690} > > Committed: https://chromium.googlesource.com/chromium/src/+/656fccff69eae8da012f0f83bcd3fc89214c5258 > > TBR=maxmorin@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG= 708139 > > Review-Url: https://codereview.chromium.org/2830813002 > Cr-Commit-Position: refs/heads/master@{#465709} > Committed: https://chromium.googlesource.com/chromium/src/+/ccdcc6ef79a614b1b1c87a78a883d9c5b19ffde2 TBR=maxmorin@chromium.org,nasko@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 708139 Review-Url: https://codereview.chromium.org/2828903002 Cr-Commit-Position: refs/heads/master@{#465748} [modify] https://crrev.com/a4be5c7090175b7410f2a9adcb447a111d152c94/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
,
Aug 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e03b42cc230039adc8aaf5ef5b804e12384aabbb commit e03b42cc230039adc8aaf5ef5b804e12384aabbb Author: Nasko Oskov <nasko@chromium.org> Date: Thu Aug 03 20:43:38 2017 Enable WebNavigationApiTest.CrossProcess(History|Fragment). Bug: 708139 Change-Id: Idb9eb18755219be4164b6fc2585aa43ed9798dc1 Reviewed-on: https://chromium-review.googlesource.com/601027 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#491836} [modify] https://crrev.com/e03b42cc230039adc8aaf5ef5b804e12384aabbb/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
,
Aug 4 2017
Failing on Win10 Tests x64 quite reliably [ RUN ] WebNavigationApiTest.CrossProcessHistory [7500:2664:0804/013612.673:WARNING:chrome_browser_main_win.cc(483)] Command line too long for RegisterApplicationRestart: --brave-new-test-launcher --cfi-diag=0 --enable-browser-side-navigation --gtest_also_run_disabled_tests --gtest_filter=WebNavigationApiTest.CrossProcessHistory --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\s\w\iovqse5r\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir3032_11112\d3032_28157" --disable-offline-auto-reload --disable-renderer-backgrounding --no-first-run --no-default-browser-check --enable-logging=stderr --safebrowsing-disable-auto-update --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --allow-legacy-extension-manifests --disable-features=NetworkPrediction --flag-switches-begin --flag-switches-end --restore-last-session about:blank [7500:2664:0804/013615.563:INFO:CONSOLE(0)] "[SUCCESS] crossProcessHistory", source: chrome-extension://diepfeppkomikhihgofeeemiepbhkhai/test_crossProcessHistory.html (0) [7500:7008:0804/013615.572:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico [7500:2664:0804/013616.225:WARNING:render_frame_host_impl.cc(2614)] OnDidStopLoading was called twice. [7500:2664:0804/013616.261:INFO:CONSOLE(0)] "[SUCCESS] crossProcessHistoryIFrame", source: chrome-extension://diepfeppkomikhihgofeeemiepbhkhai/test_crossProcessHistory.html (0) [400/642] WebNavigationApiTest.CrossProcessHistory (TIMED OUT)
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b7a75e7f6e465d1e96e4bc75fedd1e00b256545 commit 0b7a75e7f6e465d1e96e4bc75fedd1e00b256545 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Fri Aug 04 09:36:04 2017 Revert "Enable WebNavigationApiTest.CrossProcess(History|Fragment)." This reverts commit e03b42cc230039adc8aaf5ef5b804e12384aabbb. Reason for revert: both tests timeout quite reliably on Win10 Tests x64 (https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/14362) Original change's description: > Enable WebNavigationApiTest.CrossProcess(History|Fragment). > > Bug: 708139 > Change-Id: Idb9eb18755219be4164b6fc2585aa43ed9798dc1 > Reviewed-on: https://chromium-review.googlesource.com/601027 > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Commit-Queue: Nasko Oskov <nasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491836} TBR=nasko@chromium.org,alexmos@chromium.org Change-Id: Iee6a4124181b0e7761a5c77e1f65ea3cda23d4d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 708139 Reviewed-on: https://chromium-review.googlesource.com/601948 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#491976} [modify] https://crrev.com/0b7a75e7f6e465d1e96e4bc75fedd1e00b256545/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fced644e99f5d258125fa7bb2432b4170f0d5607 commit fced644e99f5d258125fa7bb2432b4170f0d5607 Author: Nasko Oskov <nasko@chromium.org> Date: Fri Jun 15 17:01:56 2018 Enable WebNavigationApiTest.CrossProcessHistory test. This test was flaky due to a race condition in navigation code, which has now been fixed. Let's try to enable it and see if the fix has helped deflake this test. Bug: 708139 Change-Id: I07c975eb6d6e207b6108f9f1cc6ed0e965981cde Reviewed-on: https://chromium-review.googlesource.com/1102660 Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#567697} [modify] https://crrev.com/fced644e99f5d258125fa7bb2432b4170f0d5607/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
,
Jun 18 2018
Looks like this test is no longer flaky, closing the bug. |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Apr 4 2017