Refactor the tests in scripts/slave/recipes/chromium_trybot.py to use post_process API |
|||||||
Issue description
Robbie has created a new post_process API for testing that certain steps are run or not. chromium_trybot.py has a whole bunch of tests for doing this. They should probably be converted to use this.
From Pawel;
--------------------
* to assert that a step named "bar" does not run, add api.post_process(post_process.DoesNotRun, 'bar')
* to assert that a step named "bar" does run, add api.post_process(post_process.MustRun, 'bar')
* to only include step named "bar" in the JSON expectation file, add api.post_process(Filter('bar'))
* to drop the JSON expectation file completely, add api.post_process(post_process.DropExpectation)
--------------------
,
Apr 4 2017
There's also some more documentation here: https://cs.chromium.org/chromium/infra/recipes-py/recipe_engine/recipe_test_api.py?l=563 (which is the api.post_process function inside of GenTests)
,
Apr 5 2017
,
May 15 2017
This is chromium related, moving to client>chrome.
,
Sep 6 2017
,
Sep 6 2017
,
Dec 8 2017
This would certainly clean up a lot of the chromium recipe's expectations and make its tests all-together saner. Our team has its plate full atm and won't be able to prioritize cleanup work like this in the immediate future.
,
Oct 19
,
Jan 17
(6 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/7b60b0180cc4b8067653106cc7c06197e6337421 commit 7b60b0180cc4b8067653106cc7c06197e6337421 Author: Karen Qian <karenqian@google.com> Date: Thu Jan 17 01:52:20 2019 Refactored tests in chromium_trybot.py to make test output more readable -Utilized post_process API to filter test output and do checks on test outputs depending on the test R=martiniss@chromium.org Bug: 708130 Change-Id: Ie0a6fe7ab5ccf7a5e0a77341a2b02e86167eea2b Reviewed-on: https://chromium-review.googlesource.com/c/1412450 Commit-Queue: Karen Qian <karenqian@google.com> Reviewed-by: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/7b60b0180cc4b8067653106cc7c06197e6337421/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests.json [delete] https://crrev.com/e74a4081b3d910b01528be580af0901615d9f0fb/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json [modify] https://crrev.com/7b60b0180cc4b8067653106cc7c06197e6337421/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets_exclude_all.json [modify] https://crrev.com/7b60b0180cc4b8067653106cc7c06197e6337421/scripts/slave/recipes/chromium_trybot.expected/analyze_runs_nothing_with_no_source_file_changes.json [modify] https://crrev.com/7b60b0180cc4b8067653106cc7c06197e6337421/scripts/slave/README.recipes.md [modify] https://crrev.com/7b60b0180cc4b8067653106cc7c06197e6337421/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_matching_exclusion.json [modify] https://crrev.com/7b60b0180cc4b8067653106cc7c06197e6337421/scripts/slave/recipes/chromium_trybot.expected/no_compile_because_of_analyze.json [modify] https://crrev.com/7b60b0180cc4b8067653106cc7c06197e6337421/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json [modify] https://crrev.com/7b60b0180cc4b8067653106cc7c06197e6337421/scripts/slave/recipes/chromium_trybot.py [modify] https://crrev.com/7b60b0180cc4b8067653106cc7c06197e6337421/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json [modify] https://crrev.com/7b60b0180cc4b8067653106cc7c06197e6337421/scripts/slave/recipes/chromium_trybot.expected/analyze_finds_invalid_target.json |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by martiniss@chromium.org
, Apr 4 2017