New issue
Advanced search Search tips

Issue 708099 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: do not start a new performance recording on page reload

Reported by kdzwinel@gmail.com, Apr 4 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36

Steps to reproduce the problem:
1. Open DevTools > Performance tab
2. Reload page

What is the expected behavior?

What went wrong?
New recording automatically starts. IMO that's unexpected and, most of the time, annoying.

Consider my workflow:
1) inspect performance of my animation in the Performance panel
2) tweak the code in IDE
3) reload page
4) ! new recording starts
5) ! click "stop"
6) ! wait for DevTools to process the recording
7) ! clear unwanted recording
8) start a new recording (one I'm actually interested in)
9) run the animation
10) stop the recording
11) go to #1

Steps 4-7, after a few repetitions, get extremely annoying. Especially, that you have to wait for DevTools to unfreeze from 'loading profile…' which takes a second or two.

In the dev environment I'm almost never interested in page load performance since this environment is very much different from the production (source maps, helper debug scripts, no minification, bundling, transpiling). I'm using Performance panel, almost exclusively, to inspect specific parts of application / website after page loads.

There seems to be a simple solution for that problem. There is a 'Reload page' button in the Performance panel interface which, right now, doesn't do anything interesting (just reloads the page). We could repurpose it into a 'Reload & Record' button making this an opt-in feature.

Did this work before? No 

Chrome version: 57.0.2987.133  Channel: stable
OS Version: OS X 10.12.3
Flash Version: 

I asked others about this feature on Twitter (22 votes): https://twitter.com/kdzwinel/status/843964719006408705 . 40% are annoyed by this feature.
 
Screen Shot 2017-04-04 at 09.29.27.png
1.9 KB View Download
Labels: Needs-Triage-M57
Owner: caseq@chromium.org

Comment 3 by caseq@chromium.org, Apr 5 2017

Cc: paulir...@chromium.org pfeldman@chromium.org
Paul, Pavel, wdyt?
Ctrl+Shift+E?
Project Member

Comment 6 by bugdroid1@chromium.org, May 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68d14c041a06c7a9acca3ec3113ce36324371d13

commit 68d14c041a06c7a9acca3ec3113ce36324371d13
Author: caseq <caseq@chromium.org>
Date: Tue May 16 19:42:30 2017

Timeline: do not start timeline on regular page reloads

This disables automatic timeline recording on page reload.
To record a reload users now should either use reload button on Timelin
panel or use a dedicated shortcut (Ctrl+Shift+E).

BUG= 708099 

Review-Url: https://codereview.chromium.org/2883143003
Cr-Commit-Position: refs/heads/master@{#472193}

[modify] https://crrev.com/68d14c041a06c7a9acca3ec3113ce36324371d13/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[delete] https://crrev.com/1f92cfbdedaecb97e8a87773deb32f98c6997351/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-auto-record-expected.txt
[delete] https://crrev.com/1f92cfbdedaecb97e8a87773deb32f98c6997351/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-auto-record.html
[add] https://crrev.com/68d14c041a06c7a9acca3ec3113ce36324371d13/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-record-reload-expected.txt
[add] https://crrev.com/68d14c041a06c7a9acca3ec3113ce36324371d13/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-record-reload.html
[modify] https://crrev.com/68d14c041a06c7a9acca3ec3113ce36324371d13/third_party/WebKit/Source/devtools/front_end/coverage/module.json
[modify] https://crrev.com/68d14c041a06c7a9acca3ec3113ce36324371d13/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
[modify] https://crrev.com/68d14c041a06c7a9acca3ec3113ce36324371d13/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
[modify] https://crrev.com/68d14c041a06c7a9acca3ec3113ce36324371d13/third_party/WebKit/Source/devtools/front_end/timeline/module.json

Comment 7 by caseq@chromium.org, May 25 2017

Status: Fixed (was: Unconfirmed)

Sign in to add a comment