New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 708078 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Apr 2017
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression : 'Add a site' overlay shrinks in size while opening it in chrome://md-settings/content/images.

Reported by rp...@etouch.net, Apr 4 2017 
Version: 59.0.3062.0 fb5c907d801f5fb0d6542c14f29c5749ae78abc7-refs/heads/master@{#461587}
OS: Windows (7,8,8.1,10)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://md-settings/content/images
2. Now click on 'Add' button and observe 'Add a site' overlay while opening it

Actual:  'Add a site' overlay shrinks in size while opening it
Expected: 'Add a site' overlay should be seen properly

This is regression issue, broken in ‘M 59’ and will soon update other info :
Good build:59.0.3061.0
Bad build: 59.0.3062.0
Actual_video.mp4
225 KB View Download
Expected_video.mp4
465 KB View Download

Comment 1 by msrchandra@chromium.org, Apr 4 2017

Labels: hasbisect-per-revision Proj-MaterialDesign-WebUI
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 59.0.3061.0 (Revision: 461353).
Bad build : 59.0.3062.0 (Revision: 461587).

You are probably looking for a change made after 461582 (known good), but no later than 461583 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/3423f23e28e4a31463540df78ed3a49b73c873c6..40e5b2648dda4c5f2766de6b34070cc54dd7e96d

@dschuyler: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Hope this is an intentional change.
Thank You.

Comment 2 by dbeam@chromium.org, Apr 10 2017

Labels: -Pri-2 Pri-3
dschuyler@: can we only SHOW the checkbox when we're sure there's an incognito session?  rather than HIDE it when we know there isn't an incognito session?

Comment 3 by dbeam@chromium.org, Apr 10 2017

Labels: Hotlist-MD-Settings-Privacy-SiteSettings

Comment 4 by dschuyler@chromium.org, Apr 18 2017 

@#2 That words for the non-incognito case, but then it resizes/flickers with incognito. To address both cases, I've added a containing div around the checkbox that does not change size based on the mode.

Comment 5 by dschuyler@chromium.org, Apr 18 2017 

Here's what the non-incognito dialog looks like with the space open for the checkbox to appear. (The incognito version is unchanged in appearance).
Screenshot from 2017-04-18 15:29:53.png
7.3 KB View Download

Comment 6 by dschuyler@chromium.org, Apr 18 2017

Status: Started (was: Assigned)
CL at https://codereview.chromium.org/2821283003/
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d07818d9b4ba24f750c132cb09153d8ec2701882

commit d07818d9b4ba24f750c132cb09153d8ec2701882
Author: dschuyler <dschuyler@chromium.org>
Date: Wed Apr 19 21:34:37 2017

[MD settings] avoid dialog resizing in add exception

This CL adds a container around the incognito checkbox that doesn't
change size. This allows the incognito checkbox to hide/show without
causing the dialog to resize.

BUG= 708078 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2821283003
Cr-Commit-Position: refs/heads/master@{#465761}

[modify] https://crrev.com/d07818d9b4ba24f750c132cb09153d8ec2701882/chrome/browser/resources/settings/site_settings/add_site_dialog.html

Comment 8 by dschuyler@chromium.org, Apr 19 2017

Status: Fixed (was: Started)
►

Sign in to add a comment