New issue
Advanced search Search tips

Issue 708057 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 596760



Sign in to add a comment

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in third_party/WebKit/public

Project Member Reported by tkent@chromium.org, Apr 4 2017

Issue description

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in third_party/WebKit/public.

https://cs.chromium.org/search/?q=%5Cb(ASSERT%7CRELEASE_ASSERT%7CASSERT_NOT_REACHED)%5C(+file:WebKit/public&type=cs

 

Comment 1 by tkent@chromium.org, Apr 4 2017

Labels: -Type-Bug Type-Task

Comment 2 by tkent@chromium.org, Apr 4 2017

> https://cs.chromium.org/search/?q=%5Cb(ASSERT%7CRELEASE_ASSERT%7CASSERT_NOT_REACHED)%5C(+file:WebKit/public&type=cs

Oh, this query contains lower-cased 'assert()'. Actually we have only three instances in WebTextDirection.h and WebPrivatePtr.h.

Owner: hs1217....@samsung.com
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/845b88e690815e8e57e8bc5505d4ac1b0295c20e

commit 845b88e690815e8e57e8bc5505d4ac1b0295c20e
Author: hs1217.lee <hs1217.lee@samsung.com>
Date: Wed Apr 19 08:41:30 2017

Replace ASSERT and ASSERT_NOT_REACHED in third_party/Webkit/public

Replace ASSERT and ASSERT_NOT_REACHED with DCHECK_op, and
NOTREACHED respectively in third_party/WebKit/public.

BUG= 708057 

Review-Url: https://codereview.chromium.org/2826923002
Cr-Commit-Position: refs/heads/master@{#465533}

[modify] https://crrev.com/845b88e690815e8e57e8bc5505d4ac1b0295c20e/third_party/WebKit/public/platform/WebPrivatePtr.h
[modify] https://crrev.com/845b88e690815e8e57e8bc5505d4ac1b0295c20e/third_party/WebKit/public/web/WebTextDirection.h

Status: Fixed (was: Started)

Sign in to add a comment