New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708056 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 596760



Sign in to add a comment

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings/

Project Member Reported by tkent@chromium.org, Apr 4 2017

Issue description

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in third_party/WebKit/Source/bindings/.

https://cs.chromium.org/search/?q=%5Cb(ASSERT%7CRELEASE_ASSERT%7CASSERT_NOT_REACHED)%5C(+file:WebKit/Source/bindings&type=cs

 
I'll work on this.
Status: Assigned (was: Untriaged)
Marking as assigned since #1 offers to work on this.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f6dc1c0458928b9e3abe4927ee99018e6945737

commit 0f6dc1c0458928b9e3abe4927ee99018e6945737
Author: bhagirathi.s <bhagirathi.s@samsung.com>
Date: Tue Apr 18 02:36:28 2017

Replacing ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in bindings
with DCHECK_op, NOTREACHED,CHECK_op respectively

BUG= 708056 

Review-Url: https://codereview.chromium.org/2817533003
Cr-Commit-Position: refs/heads/master@{#465109}

[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/AUTHORS
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/DOMWrapperMap.h
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/Dictionary.h
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/Iterable.h
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/ScriptEventListener.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/ScriptFunction.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseProperty.h
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/ScriptState.h
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/ScriptValue.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/ScriptValue.h
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V0CustomElementBinding.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V8Binding.h
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V8DOMActivityLogger.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V8IdleTaskRunner.h
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V8StringResource.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V8StringResource.h
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V8ValueCache.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V8ValueCache.h
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/custom/V8IntersectionObserverCustom.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/modules/v8/ToV8ForModules.h
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
[modify] https://crrev.com/0f6dc1c0458928b9e3abe4927ee99018e6945737/third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f3bcd31ce23e2008493305d47ff67d208dae95a

commit 3f3bcd31ce23e2008493305d47ff67d208dae95a
Author: pilgrim <pilgrim@chromium.org>
Date: Tue May 02 00:23:27 2017

Replace ASSERT_NOT_REACHED with NOTREACHED in bindings/

BUG= 708056 

Review-Url: https://codereview.chromium.org/2850833002
Cr-Commit-Position: refs/heads/master@{#468503}

[modify] https://crrev.com/3f3bcd31ce23e2008493305d47ff67d208dae95a/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

Comment 5 by tkent@chromium.org, May 23 2017

Owner: pilgrim@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment