New issue
Advanced search Search tips

Issue 708052 link

Starred by 1 user
Status: Fixed
Owner:
ma...@chromium.org
Closed: Apr 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , iOS , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Payments] Core: refactor PaymentMethodData parsing to be used on iOS

Project Member Reported by ma...@chromium.org, Apr 4 2017 
Couple of steps
(1) Bring PaymentMethodData to components/payments/core
(2) Change the parsing function of supported methods/networks/types to use this object instead.
(3) Transform mojom::PaymentMethodDataPtr to PaymentMethodData and use that for the parsing. 
(4) Use this on iOS.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a0f508c228156c161f59858e65c6ee06c14d650

commit 0a0f508c228156c161f59858e65c6ee06c14d650
Author: mathp <mathp@chromium.org>
Date: Tue Apr 04 19:27:56 2017

[Payments] Move PaymentMethodData to components/payments/core

BUG= 708052 
TEST=components_unittests

Review-Url: https://codereview.chromium.org/2797633002
Cr-Commit-Position: refs/heads/master@{#461802}

[modify] https://crrev.com/0a0f508c228156c161f59858e65c6ee06c14d650/components/payments/core/BUILD.gn
[add] https://crrev.com/0a0f508c228156c161f59858e65c6ee06c14d650/components/payments/core/payment_method_data.cc
[add] https://crrev.com/0a0f508c228156c161f59858e65c6ee06c14d650/components/payments/core/payment_method_data.h
[add] https://crrev.com/0a0f508c228156c161f59858e65c6ee06c14d650/components/payments/core/payment_method_data_unittest.cc
[modify] https://crrev.com/0a0f508c228156c161f59858e65c6ee06c14d650/ios/chrome/browser/payments/payment_request_test_util.mm
[modify] https://crrev.com/0a0f508c228156c161f59858e65c6ee06c14d650/ios/chrome/browser/payments/payment_request_unittest.mm
[modify] https://crrev.com/0a0f508c228156c161f59858e65c6ee06c14d650/ios/chrome/browser/payments/payment_request_util.mm
[modify] https://crrev.com/0a0f508c228156c161f59858e65c6ee06c14d650/ios/web/payments/payment_request.cc
[modify] https://crrev.com/0a0f508c228156c161f59858e65c6ee06c14d650/ios/web/payments/payment_request_unittest.cc
[modify] https://crrev.com/0a0f508c228156c161f59858e65c6ee06c14d650/ios/web/public/payments/payment_request.h
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4900df7526f2d89561a1ee4a024ca0be78b60169

commit 4900df7526f2d89561a1ee4a024ca0be78b60169
Author: mathp <mathp@chromium.org>
Date: Wed Apr 05 14:49:42 2017

[Payments] base::string16 -> std::string in PaymentMethodData

base::string16 is overkill for this.

BUG= 708052 
TEST=existing

Review-Url: https://codereview.chromium.org/2797833002
Cr-Commit-Position: refs/heads/master@{#462069}

[modify] https://crrev.com/4900df7526f2d89561a1ee4a024ca0be78b60169/components/payments/core/payment_method_data.cc
[modify] https://crrev.com/4900df7526f2d89561a1ee4a024ca0be78b60169/components/payments/core/payment_method_data.h
[modify] https://crrev.com/4900df7526f2d89561a1ee4a024ca0be78b60169/components/payments/core/payment_method_data_unittest.cc
[modify] https://crrev.com/4900df7526f2d89561a1ee4a024ca0be78b60169/ios/chrome/browser/payments/payment_request.mm
[modify] https://crrev.com/4900df7526f2d89561a1ee4a024ca0be78b60169/ios/chrome/browser/payments/payment_request_test_util.mm
[modify] https://crrev.com/4900df7526f2d89561a1ee4a024ca0be78b60169/ios/chrome/browser/payments/payment_request_unittest.mm
[modify] https://crrev.com/4900df7526f2d89561a1ee4a024ca0be78b60169/ios/chrome/browser/payments/payment_request_util.mm
[modify] https://crrev.com/4900df7526f2d89561a1ee4a024ca0be78b60169/ios/web/payments/payment_request_unittest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b65623a9c0565962586271410beb98e53c2beaee

commit b65623a9c0565962586271410beb98e53c2beaee
Author: mathp <mathp@chromium.org>
Date: Thu Apr 06 02:01:54 2017

[Payments] Move parsing the PaymentMethodData to "core"

This will allow it to be used on iOS as well. We now copy the
mojom::PaymentMethodData entries to a common type
(PaymentMethodData) before parsing.

BUG= 708052 
TEST=existing components_unittests (PaymentRequestSpec)

Review-Url: https://codereview.chromium.org/2800713003
Cr-Commit-Position: refs/heads/master@{#462323}

[modify] https://crrev.com/b65623a9c0565962586271410beb98e53c2beaee/components/payments/content/payment_request_spec.cc
[modify] https://crrev.com/b65623a9c0565962586271410beb98e53c2beaee/components/payments/content/payment_request_spec.h
[modify] https://crrev.com/b65623a9c0565962586271410beb98e53c2beaee/components/payments/core/payment_request_data_util.cc
[modify] https://crrev.com/b65623a9c0565962586271410beb98e53c2beaee/components/payments/core/payment_request_data_util.h

Comment 5 by ma...@chromium.org, Apr 7 2017

Status: Fixed (was: Assigned)

Comment 6 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
►

Sign in to add a comment