Only enable WiFi powersave mode on non-embedded devices |
|||||
Issue descriptionCL:439884 removes handling of WiFi powersave mode from laptop-mode-tools (LMT) and adds a udev rule that statically enables WiFi powersave mode at boot time. The assumption was that LMT is installed on all CrOS devices, however this is not correct. LMT is not included on 'embedded' devices (USE flag cros_embedded=1), therefore WiFi powersave mode should not be enabled on those devices. Only install the powerknobs udev rules when cros_embedded is not set, as done with the autosuspend rules.
,
Apr 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/b4f69dc30faa73400b9d995055ef509cbb740657 commit b4f69dc30faa73400b9d995055ef509cbb740657 Author: Matthias Kaehlcke <mka@chromium.org> Date: Mon Apr 17 21:06:19 2017 power: Move powerknobs.rules to sub-directory 'optional' CL:439884 removed handling of WiFi powersave mode from laptop-mode-tools (LMT) and added a udev rule that statically enables WiFi powersave mode at boot time. The assumption was that LMT is installed on all CrOS devices, however this is not correct. LMT is not included on 'embedded' devices (USE=cros_embedded), therefore WiFi powersave mode should not be enabled on those devices. Move the powerknobs udev rules to the sub-directory 'optional' to allow the ebuild to install it only when USE=powerknobs is set. BUG= chromium:708017 TEST=emerge-pyro power_manager ls /build/pyro/lib/udev/rules.d/99-powerknobs.rules => exists emerge-whirlwind power_manager ls /build/whirlwind/lib/udev/rules.d/99-powerknobs.rules => No such file or directory CQ-DEPEND=CL:468007 Change-Id: I325ac45005f92873b17a6e0a41befbd629fdbda9 Reviewed-on: https://chromium-review.googlesource.com/467987 Commit-Ready: Matthias Kaehlcke <mka@chromium.org> Tested-by: Matthias Kaehlcke <mka@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [rename] https://crrev.com/b4f69dc30faa73400b9d995055ef509cbb740657/power_manager/udev/optional/99-powerknobs.rules
,
Apr 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7e2ac8b7a66451afefaf444b54e30a9335fc6875 commit 7e2ac8b7a66451afefaf444b54e30a9335fc6875 Author: Matthias Kaehlcke <mka@chromium.org> Date: Mon Apr 17 21:06:19 2017 power: Only install powerknobs udev rules when USE=powerknobs is set CL:439884 removed handling of WiFi powersave mode from laptop-mode-tools (LMT) and added a udev rule that statically enables WiFi powersave mode at boot time. The assumption was that LMT is installed on all CrOS devices, however this is not correct. LMT is not included on devices with USE=cros_embedded, therefore WiFi powersave mode should not be enabled on those devices. In the long term we want to get rid of 'cros_embedded', therefore we check USE=powerknobs instead of USE=cros_embeddded to determine whether the udev rules should be installed. BUG= chromium:708017 TEST=emerge-pyro power_manager ls /build/pyro/lib/udev/rules.d/99-powerknobs.rules => exists emerge-whirlwind power_manager ls /build/whirlwind/lib/udev/rules.d/99-powerknobs.rules => No such file or directory CQ-DEPEND=CL:467987 Change-Id: Ic3454d749ae6ec72f70983bc7f947dfee2e07974 Reviewed-on: https://chromium-review.googlesource.com/468007 Commit-Ready: Matthias Kaehlcke <mka@chromium.org> Tested-by: Matthias Kaehlcke <mka@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Matthias Kaehlcke <mka@chromium.org> [modify] https://crrev.com/7e2ac8b7a66451afefaf444b54e30a9335fc6875/chromeos-base/power_manager/power_manager-9999.ebuild
,
Apr 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1b991b714ebd09de01f03ee9731223026d94f923 commit 1b991b714ebd09de01f03ee9731223026d94f923 Author: Matthias Kaehlcke <mka@chromium.org> Date: Mon Apr 17 21:06:19 2017 power: Use USE=powerknobs to control installation of autosuspend rules In the longer term we want to get rid of the 'cros_embedded' USE flag. Use the new USE flag 'powerknobs' to determine whether the autosuspend udev rules should be installed. BUG= chromium:708017 TEST=emerge-gru power_manager ls /build/gru/lib/udev/rules.d/99-autosuspend.rules => exists emerge-whirlwind power_manager ls /build/whirlwind/lib/udev/rules.d/99-autosuspend.rules => No such file or directory Change-Id: Icfa2b63a40fcba1c29cd37e3e665fcc6d0fa24b0 Reviewed-on: https://chromium-review.googlesource.com/474064 Commit-Ready: Matthias Kaehlcke <mka@chromium.org> Tested-by: Matthias Kaehlcke <mka@chromium.org> Reviewed-by: Matthias Kaehlcke <mka@chromium.org> [modify] https://crrev.com/1b991b714ebd09de01f03ee9731223026d94f923/chromeos-base/power_manager/power_manager-9999.ebuild
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Apr 13 2017