Status area visibility is not consistent between oobe screen switch |
||
Issue descriptionOn tot Chrome, If we start with oobe first welcome screen, we can see status area visible, then click Enable debugging features link, we can see status area invisible, then click Cancel button on enable debugging features page, which will return to the welcome page. We can see now status area is invisible. This causes the inconsistency of status area visibility. This is because WizardController::ShowCurrentScreen() doesn't update status area visibility. We need to have a cleanup here.
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/509a5b53985357e3dce645ad8d92b6769f438a9f commit 509a5b53985357e3dce645ad8d92b6769f438a9f Author: warx <warx@chromium.org> Date: Fri Apr 07 23:22:41 2017 cros: UpdateStatusAreaVisibility in WizardControllor::ShowCurrentScreen() Changes: (1) Intentionally remove SetStatusAreaVisible method as it doesn't save much code. (2) For each screen-related status area visibility call, using UpdateStatusAreaVisibilityForScreen method. (3) Add UpdateStatusAreaVisibilityForScreen in ShowCurrentScreen() to fix the bug. BUG= 708011 TEST=test that reporter's bug is fixed Review-Url: https://codereview.chromium.org/2791223004 Cr-Commit-Position: refs/heads/master@{#463044} [modify] https://crrev.com/509a5b53985357e3dce645ad8d92b6769f438a9f/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/509a5b53985357e3dce645ad8d92b6769f438a9f/chrome/browser/chromeos/login/wizard_controller.h
,
Apr 7 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by warx@chromium.org
, Apr 4 2017Labels: -OS-Chrome