New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708010 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 708009



Sign in to add a comment

Remove deprecated config options from service_manager

Project Member Reported by dsansome@chromium.org, Apr 4 2017

Issue description

--args, --root-directory and --tool.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7ea04b43ccfd0e617502925011a411f085797d5d

commit 7ea04b43ccfd0e617502925011a411f085797d5d
Author: David Sansome <dsansome@chromium.org>
Date: Wed Jun 07 01:39:29 2017

Properly deprecate the root_directory config option.

Replace it with an explicit cipd_version_file option

Bug:  708010 
Change-Id: I1daf3d08d7445a8992bbcefa2b981ea52474b311
Reviewed-on: https://chromium-review.googlesource.com/525352
Commit-Queue: Dave Sansome <dsansome@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/7ea04b43ccfd0e617502925011a411f085797d5d/infra/services/service_manager/README.md
[modify] https://crrev.com/7ea04b43ccfd0e617502925011a411f085797d5d/infra/services/service_manager/test/config_watcher_test.py
[modify] https://crrev.com/7ea04b43ccfd0e617502925011a411f085797d5d/infra/services/service_manager/service.py
[modify] https://crrev.com/7ea04b43ccfd0e617502925011a411f085797d5d/infra/services/service_manager/config_watcher.py
[modify] https://crrev.com/7ea04b43ccfd0e617502925011a411f085797d5d/infra/services/service_manager/test/version_finder_test.py
[modify] https://crrev.com/7ea04b43ccfd0e617502925011a411f085797d5d/infra/services/service_manager/test/service_test.py
[modify] https://crrev.com/7ea04b43ccfd0e617502925011a411f085797d5d/infra/services/service_manager/version_finder.py
[modify] https://crrev.com/7ea04b43ccfd0e617502925011a411f085797d5d/infra/services/service_manager/__main__.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/67741431f093398375aedc54d4d1a56a7abc493b

commit 67741431f093398375aedc54d4d1a56a7abc493b
Author: David Sansome <dsansome@google.com>
Date: Wed Jun 07 03:57:10 2017

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/3d4b2aa92b4daf32b06b86ba419ce20d5e338855

commit 3d4b2aa92b4daf32b06b86ba419ce20d5e338855
Author: David Sansome <dsansome@google.com>
Date: Wed Jun 07 04:16:18 2017

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/10f8637e68e7474ccdc41e3d117697b515a21b28

commit 10f8637e68e7474ccdc41e3d117697b515a21b28
Author: Katie Thomas <katthomas@google.com>
Date: Thu Jun 08 17:54:46 2017

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/10f8637e68e7474ccdc41e3d117697b515a21b28

commit 10f8637e68e7474ccdc41e3d117697b515a21b28
Author: Katie Thomas <katthomas@google.com>
Date: Thu Jun 08 17:54:46 2017

Status: Fixed (was: Assigned)

Sign in to add a comment