New issue
Advanced search Search tips

Issue 707999 link

Starred by 1 user
Status: Fixed
Owner:
ayatane@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Autotest needs standard label library

Project Member Reported by ayatane@chromium.org, Apr 4 2017 
We do a lot of ad-hoc label logic (adding label strings, adding colons, parsing label strings with colons, etc.)  We really need a standard library for this in Autotest
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e7ec6636575859eb147d4e8dc3f66cd30f7c66ef

commit e7ec6636575859eb147d4e8dc3f66cd30f7c66ef
Author: Allen Li <ayatane@chromium.org>
Date: Sat Apr 22 04:57:36 2017

[autotest] Standardize label logic

BUG= chromium:707999 
TEST=Run unit tests

Change-Id: Ibb5ad25492f6169984947858d502b8d98053b907
Reviewed-on: https://chromium-review.googlesource.com/414532
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[add] https://crrev.com/e7ec6636575859eb147d4e8dc3f66cd30f7c66ef/utils/labellib.py
[add] https://crrev.com/e7ec6636575859eb147d4e8dc3f66cd30f7c66ef/utils/labellib_unittest.py
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/89711f7020f6961a23571b12f6ec1598198ed468

commit 89711f7020f6961a23571b12f6ec1598198ed468
Author: Allen Li <ayatane@chromium.org>
Date: Sat Apr 29 05:25:39 2017

[autotest] Use labellib for provision.py label constants

BUG= chromium:707999 
TEST=Run unit tests

Change-Id: Ifaa577526ba5a8f2262fe344b60eaab0ac941289
Reviewed-on: https://chromium-review.googlesource.com/446877
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/89711f7020f6961a23571b12f6ec1598198ed468/server/cros/provision.py
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/aaabda844ee4b9d89f7440c29a2f61db1ad34395

commit aaabda844ee4b9d89f7440c29a2f61db1ad34395
Author: Allen Li <ayatane@chromium.org>
Date: Sat Apr 29 05:25:40 2017

[autotest] Use labellib for version label functions

BUG= chromium:707999 
TEST=Run unit tests

Change-Id: I3979b9f7a19ae174226c6a15a0573c560baa1614
Reviewed-on: https://chromium-review.googlesource.com/446878
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/aaabda844ee4b9d89f7440c29a2f61db1ad34395/server/cros/provision.py
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/aaabda844ee4b9d89f7440c29a2f61db1ad34395

commit aaabda844ee4b9d89f7440c29a2f61db1ad34395
Author: Allen Li <ayatane@chromium.org>
Date: Sat Apr 29 05:25:40 2017

[autotest] Use labellib for version label functions

BUG= chromium:707999 
TEST=Run unit tests

Change-Id: I3979b9f7a19ae174226c6a15a0573c560baa1614
Reviewed-on: https://chromium-review.googlesource.com/446878
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/aaabda844ee4b9d89f7440c29a2f61db1ad34395/server/cros/provision.py
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/606673f8e1e969dfa595a9654e17bc4643f8ef68

commit 606673f8e1e969dfa595a9654e17bc4643f8ef68
Author: Allen Li <ayatane@chromium.org>
Date: Sat Apr 29 05:25:40 2017

[autotest] Add _get_label_action()

BUG= chromium:707999 
TEST=Run unit tests

Change-Id: I901fdf3ebb206c7e77716658a6656740c04be616
Reviewed-on: https://chromium-review.googlesource.com/446879
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/606673f8e1e969dfa595a9654e17bc4643f8ef68/server/cros/provision.py
[modify] https://crrev.com/606673f8e1e969dfa595a9654e17bc4643f8ef68/server/cros/provision_unittest.py
Project Member

Comment 6 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ceb24430d30cb1fe7f9a407e1137f693afeb5002

commit ceb24430d30cb1fe7f9a407e1137f693afeb5002
Author: Allen Li <ayatane@chromium.org>
Date: Tue May 02 02:18:07 2017

[autotest] Fix naming and docstring for test_for()

BUG= chromium:707999 
TEST=Run unit tests

Change-Id: Ie9f2c220597eb0f52159d4c2923a9b619839459a
Reviewed-on: https://chromium-review.googlesource.com/446881
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/ceb24430d30cb1fe7f9a407e1137f693afeb5002/server/cros/provision.py
Project Member

Comment 7 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/95e930a2dbd9ca6a9e84b83e8551f9ff26b003c8

commit 95e930a2dbd9ca6a9e84b83e8551f9ff26b003c8
Author: Allen Li <ayatane@chromium.org>
Date: Tue May 02 02:18:07 2017

[autotest] Use _get_label_action() for acts_on()

BUG= chromium:707999 
TEST=Run unit tests

Change-Id: I69344a64b010113662e4b6e768ce7e790a17d3ff
Reviewed-on: https://chromium-review.googlesource.com/446880
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/95e930a2dbd9ca6a9e84b83e8551f9ff26b003c8/server/cros/provision.py
Project Member

Comment 8 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5b623128d7884f10b0d922bd4f2b263a4fef348b

commit 5b623128d7884f10b0d922bd4f2b263a4fef348b
Author: Allen Li <ayatane@chromium.org>
Date: Tue May 02 02:18:07 2017

[autotest] Fix stupid capabilities/configuration naming

BUG= chromium:707999 
TEST=Run unit tests

Change-Id: Ib3df43a053cb6cd5c4c181c414e26390e3330889
Reviewed-on: https://chromium-review.googlesource.com/446882
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/5b623128d7884f10b0d922bd4f2b263a4fef348b/server/cros/provision.py
Project Member

Comment 9 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/baa4ec937121db8fe72874c8bc9fb412e06027cb

commit baa4ec937121db8fe72874c8bc9fb412e06027cb
Author: Allen Li <ayatane@chromium.org>
Date: Tue May 02 02:18:08 2017

[autotest] Rewrite lambda

BUG= chromium:707999 
TEST=Run unit tests

Change-Id: Ic0618e605b6a554ee2c22af967a9aada9960882e
Reviewed-on: https://chromium-review.googlesource.com/446883
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/baa4ec937121db8fe72874c8bc9fb412e06027cb/server/cros/provision.py
Project Member

Comment 10 by bugdroid1@chromium.org, May 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2115458e61fe5fad9fe5d87e955a953af44a8633

commit 2115458e61fe5fad9fe5d87e955a953af44a8633
Author: Allen Li <ayatane@chromium.org>
Date: Sat May 20 10:55:10 2017

[autotest] Make run_special_task_actions() a method

BUG= chromium:707999 
TEST=Run unit tests

Change-Id: I02914ce27664f76e6f0e4fe37b96f92fd4a3373b
Reviewed-on: https://chromium-review.googlesource.com/446885
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/2115458e61fe5fad9fe5d87e955a953af44a8633/server/cros/provision.py
Project Member

Comment 11 by bugdroid1@chromium.org, May 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/74a68665a7ac45d07d223aa195c044058809447b

commit 74a68665a7ac45d07d223aa195c044058809447b
Author: Allen Li <ayatane@chromium.org>
Date: Sat May 20 10:55:10 2017

[autotest] Privatize sort_actionable_labels()

BUG= chromium:707999 
TEST=Run unit tests

Change-Id: I85d16ac1238b0b9f5a6b85041f2f0ca611307872
Reviewed-on: https://chromium-review.googlesource.com/446886
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/74a68665a7ac45d07d223aa195c044058809447b/server/cros/provision.py
Project Member

Comment 12 by bugdroid1@chromium.org, May 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2115458e61fe5fad9fe5d87e955a953af44a8633

commit 2115458e61fe5fad9fe5d87e955a953af44a8633
Author: Allen Li <ayatane@chromium.org>
Date: Sat May 20 10:55:10 2017

[autotest] Make run_special_task_actions() a method

BUG= chromium:707999 
TEST=Run unit tests

Change-Id: I02914ce27664f76e6f0e4fe37b96f92fd4a3373b
Reviewed-on: https://chromium-review.googlesource.com/446885
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/2115458e61fe5fad9fe5d87e955a953af44a8633/server/cros/provision.py
Project Member

Comment 13 by bugdroid1@chromium.org, May 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d575f6445a6438706531946fbfa90118d48d5f66

commit d575f6445a6438706531946fbfa90118d48d5f66
Author: Allen Li <ayatane@chromium.org>
Date: Wed May 24 06:59:10 2017

[autotest] provision.py refactor

This commit is the combination of multiple commits.  Their commit
messages are as follows:

commit 74fd09c73d5a0b00de3b2b26c254f7fd2589d762
Author: Allen Li <ayatane@chromium.org>
Date:   Wed Feb 22 18:04:46 2017 -0800

    [autotest] Privatize action_for()

    BUG= chromium:707999 
    TEST=Run unit tests

    Change-Id: I89fe2f368f521f7670d8627dc5fd1425f5b33809

commit a7d2f9408185f8cba30952aa18ba40c2b4fb7b96
Author: Allen Li <ayatane@chromium.org>
Date:   Tue Apr 4 15:14:22 2017 -0700

    [autotest] Inline _action_for()

    BUG= chromium:707999 
    TEST=Run unit tests

    Change-Id: Iec003558376b4d98901b209cc4793ca2443c3904

commit 01995f7dc53fcf82502b3abacdcd5d6c616ab847
Author: Allen Li <ayatane@chromium.org>
Date:   Tue Apr 4 15:18:10 2017 -0700

    [autotest] Replace label logic in _sort_actionable_labels()

    BUG= chromium:707999 
    TEST=Run unit tests

    Change-Id: Ib083b558d5627bdf8149604680f4a16d0372e141

commit 0a871fa273f3f4801ce20025aa6a1abca4f7034f
Author: Allen Li <ayatane@chromium.org>
Date:   Tue Apr 4 15:19:35 2017 -0700

    [autotest] Remove useless comment

    BUG= chromium:707999 
    TEST=Run unit tests

    Change-Id: I482610b597248528eb15272713d7a8ccbf663680

commit bff7f7f92e2945bc3fca2937b6bd07ef40e80213
Author: Allen Li <ayatane@chromium.org>
Date:   Tue Apr 4 15:25:10 2017 -0700

    [autotest] Extract _get_action_priority()

    BUG= chromium:707999 
    TEST=Run unit tests

    Change-Id: I33f19161700372f1e9f22e01210cac8786b3d296

commit 4f6fc86b0b2d8d6be7615a868d18e863f9fd75dd
Author: Allen Li <ayatane@chromium.org>
Date:   Tue Apr 4 15:26:14 2017 -0700

    [autotest] Inline sort key

    BUG= chromium:707999 
    TEST=Run unit tests

    Change-Id: I9f5a801d87fdf2a677d26ab167a78074c02ced88

commit 94eb973f8b433398de545eb21727b17af63a097b
Author: Allen Li <ayatane@chromium.org>
Date:   Tue Apr 4 15:33:53 2017 -0700

    [autotest] Extract _filter_unactionable_labels()

    BUG= chromium:707999 
    TEST=Run unit tests

    Change-Id: Ia020fd61b14fc7e18dd8c28c7cc76205bb33cb0c

commit 1ff8574b845214114d6fdbcb395a1b1bcbdc2046
Author: Allen Li <ayatane@chromium.org>
Date:   Tue Apr 4 15:34:58 2017 -0700

    [autotest] Extract _filter_actionable_labels()

    BUG= chromium:707999 
    TEST=Run unit tests

    Change-Id: Ia835f03d5d63c1f558700b0e04cdb1b176345790

commit 8ccb77cd5299ed5c3411824881ba079ad9adcde0
Author: Allen Li <ayatane@chromium.org>
Date:   Tue Apr 4 15:36:10 2017 -0700

    [autotest] Remove partition usage

    BUG= chromium:707999 
    TEST=Run unit tests

    Change-Id: I71538cef1500eb4ef7a44b62d3920ac117c05e60

commit 272781d81936f37c01d838ca5f1832fe23c5a141
Author: Allen Li <ayatane@chromium.org>
Date:   Tue Apr 4 15:37:54 2017 -0700

    [autotest] Inline _sort_actionable_labels()

    BUG= chromium:707999 
    TEST=Run unit tests

    Change-Id: Ib89a44ad969e95ec9bdae9f134e8bc5833d187a9

commit 87153b8ac2d34081d80b7d6671b1ac1249661bdf
Author: Allen Li <ayatane@chromium.org>
Date:   Tue Apr 4 15:39:19 2017 -0700

    [autotest] Simplify sorting

    BUG= chromium:707999 
    TEST=Run unit tests

    Change-Id: I90a6704d8bcb4bf6a716009df9877ee15f8f69fd

commit 4993d92cda071511d77cfb12f8ad803f36c4071d
Author: Allen Li <ayatane@chromium.org>
Date:   Tue Apr 4 15:44:11 2017 -0700

    [autotest] Extract _actions_and_values_iter()

    BUG= chromium:707999 
    TEST=Run unit tests

    Change-Id: I2c39b05c305a8cdf264b42b362ef5ab5c4159321

commit 0242e5e27f15f46ea702412104364b60122588ea
Author: Allen Li <ayatane@chromium.org>
Date:   Fri Apr 28 16:07:27 2017 -0700

    [autotest] Fix warning stack level

    Make the warning report who the caller is.

    BUG=None
    TEST=None

    Change-Id: I7f3cfe6b6a17f0014cb7ef36c33451cda90fb1ba

Change-Id: I2e2638e180c389de556b5ab0ec13e51fc5be3569
Reviewed-on: https://chromium-review.googlesource.com/513226
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/d575f6445a6438706531946fbfa90118d48d5f66/server/cros/provision.py

Comment 14 by ayatane@chromium.org, May 24 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment