New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 707993 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Successful build getting marked as aborted

Project Member Reported by davidri...@chromium.org, Apr 3 2017

Issue description

Comment 1 by nxia@chromium.org, Apr 4 2017

At 00:15:12, master/paladin/14143 found cyan-paladin/builds/2124 was still running, it sent the 'Cancel' request to the Buildbucket. At 00:15:13, cyan-paladin/builds/2124 completed successfully before it got cancelled by the buildbucket. At 00:15:2*,  master/paladin/14143 inserted 'abort' status for cyan-paladin/builds/2124. 

we can improve db.FinishBuild to update the entry only when final=False.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/5f92f7f56fee77eace831759cb341b71aef8ebd2

commit 5f92f7f56fee77eace831759cb341b71aef8ebd2
Author: Ningning Xia <nxia@chromium.org>
Date: Fri Apr 07 21:15:35 2017

FinishBuild: add strict option to only update build status when final=False.

db.FinishBuild provides the strict option (default to True). When strict
is on, FinishBuild only allows build status updates when final=False.

BUG= chromium:707993 
TEST=unit_tests, cidb_integration_test

Change-Id: I4ca9b63ebab5186d0ae57a4f72791c612f33b651
Reviewed-on: https://chromium-review.googlesource.com/469256
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/5f92f7f56fee77eace831759cb341b71aef8ebd2/cbuildbot/stages/build_stages.py
[modify] https://crrev.com/5f92f7f56fee77eace831759cb341b71aef8ebd2/lib/fake_cidb.py
[modify] https://crrev.com/5f92f7f56fee77eace831759cb341b71aef8ebd2/lib/cidb.py
[modify] https://crrev.com/5f92f7f56fee77eace831759cb341b71aef8ebd2/lib/cidb_integration_test.py

Comment 3 by nxia@chromium.org, May 12 2017

We've already removed the logic of inserting 'abort' status for slaves from the next master. The information of ignored slaves can be found in buildMessageTable.

Comment 4 by nxia@chromium.org, May 12 2017

Status: Fixed (was: Untriaged)

Sign in to add a comment