New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 707991 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Should prompt for user OK before opening App Store URLs in Chrome

Project Member Reported by pkl@chromium.org, Apr 3 2017

Issue description

App Version (from "Chrome Settings > About Chrome"): 57.0.2987.137
iOS Version: 10.3.2 (beta)
Device: iPhone 5S

Steps to reproduce:
Run Chrome and view http://browsingtest.appspot.com/external_url.html
Click on App Store URL itms: and http: links.

Observed behavior: 
No prompt is offered before App Store is launched. 

Expected behavior: 
Safari on 10.3.2 prompts user before launching App Store.

Frequency: 
<number of times you were able to reproduce> 

Additional comments: 

 

Comment 1 by pkl@chromium.org, May 8 2017

Labels: -Pri-2 M-60 Pri-1

Comment 2 by pkl@chromium.org, May 12 2017

Status: Started (was: Assigned)

Comment 3 by pkl@chromium.org, May 12 2017

Cc: mrefaat@chromium.org pinkerton@chromium.org jasonkliu@chromium.org mard...@chromium.org
 Issue 708147  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/825edf8e5dadff7bce102fdf37d5be5128490c45

commit 825edf8e5dadff7bce102fdf37d5be5128490c45
Author: pkl <pkl@chromium.org>
Date: Wed May 17 23:16:16 2017

Prompts user before transferring to App Store

Uses more aggressive prompting like iOS 10.3. Prompts user even if
user tapped on a link. In earlier versions of iOS, prompts are presented
only if user did not tap on a link.

BUG= 707991 
TEST=test links on browsingtest.appspot.com/external_url.html

Review-Url: https://codereview.chromium.org/2878813003
Cr-Commit-Position: refs/heads/master@{#472597}

[modify] https://crrev.com/825edf8e5dadff7bce102fdf37d5be5128490c45/ios/chrome/browser/web/external_app_launcher.mm

Comment 6 by pkl@chromium.org, May 18 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in iPhone7 with iOS 10.3.2
Prompt to open Appstore is displayed when tapping on links with http and itms scheme
Build: 60.0.3109.0 canary
Device: iPhone7

Sign in to add a comment