Don't try to update incessently when Shell APK version is out of date |
||
Issue descriptionIn ToT, because the Shell APK version is out of date, Chrome will try to update each time that you move the WebAPK to the foreground. We should have a minimum delay between update requests
,
Apr 4 2017
Agree, and I feel we need to give the server enough time to update the template. Maybe 2 days?
,
Apr 4 2017
So I guess a single "try to update" might encompass multiple update requests (since we try to update in the background a few times first), but I think it would be reasonable to start the process not more than once in 24h.
,
Apr 4 2017
I thought WebApkUpdateManager was supposed to already throttle upgrade requests. Or does it not for shell apk version?
,
Apr 4 2017
oh i see it's short-circuited in that case - ya, we should remove that
,
Apr 4 2017
On the server side, the template is first rolled out to the test server, and if everything is ok, it will roll out to prod server. So the test server part takes sometime, but Glenn think 2-3 days will be enough. I don't think removing the Shell APK version check is enough, we should give the shell APK version retry a different time interval, since it depends on how fast the WAM Server could adopt the new template.
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d0fd5239302fd191a795053515111df9f9fffbb commit 6d0fd5239302fd191a795053515111df9f9fffbb Author: hanxi <hanxi@chromium.org> Date: Wed Apr 19 13:37:38 2017 Don't try to update incessently when Shell APK version is out of date. After the shell_apk_version increases in Chrome, it takes sometime before the new shell APK template rolls out to the WebAPK Server. To avoid a WebAPK request update each time it is launched, we add a minimum delay between each request that is due to shell apk version is low. BUG= 707990 Review-Url: https://codereview.chromium.org/2790213004 Cr-Commit-Position: refs/heads/master@{#465580} [modify] https://crrev.com/6d0fd5239302fd191a795053515111df9f9fffbb/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java [modify] https://crrev.com/6d0fd5239302fd191a795053515111df9f9fffbb/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java [modify] https://crrev.com/6d0fd5239302fd191a795053515111df9f9fffbb/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java
,
May 2 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by pkotw...@chromium.org
, Apr 3 2017