chromeos-base/chromeos-installer build fails with llvm-next |
||
Issue descriptionchromeos-base/chromeos-installer fails to build with llvm-next. The build fails with a few "error: format string is not a string literal [-Werror,-Wformat-nonliteral]" messages. For example, see this build log from the llvm-next toolchain-buildbot for amd64: https://uberchromegw.corp.google.com/i/chromeos/builders/amd64-llvm-next-toolchain/builds/213/steps/BuildPackages%20%5Bafdo_use%5D/logs/stdio Similar failures are present on arm and arm64 toolchain buildbots as well.
,
Apr 4 2017
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/b2d9fd1b7fcd386ab518b4aa60668195a9f808c1 commit b2d9fd1b7fcd386ab518b4aa60668195a9f808c1 Author: Aseda Aboagye <aaboagye@google.com> Date: Tue Apr 04 21:08:15 2017 installer: Add format attribute to VbExError(). Apparently LLVM requires a format attribute for printf style functions. This commit adds that attribute. BUG= chromium:707983 ,chromium:695151 BRANCH=None TEST=`USE="llvm-next" sudo emerge llvm clang; emerge-elm chromeos-installer` Change-Id: I18e905a65861961a891443fcae2dea50a03875e4 Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/467046 Commit-Ready: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/b2d9fd1b7fcd386ab518b4aa60668195a9f808c1/installer/inst_util.cc
,
Apr 4 2017
Verified locally when uploading CL.
,
Apr 5 2017
Thanks for the quick fix. |
||
►
Sign in to add a comment |
||
Comment 1 by manojgupta@chromium.org
, Apr 4 2017Labels: -Pri-2 Pri-1
Owner: aaboagye@chromium.org