keyboard navigation focus get lost on Enable debugging features screen |
|||
Issue descriptionToT chrome: (1) Focus is on password, (2) a arrow up or a series of arrow down, (3) focus will get lost, could never return to password input again.
,
Apr 4 2017
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53436789712c58d9f7d512e6615b4acf46e52f28 commit 53436789712c58d9f7d512e6615b4acf46e52f28 Author: foolip <foolip@chromium.org> Date: Thu Apr 06 04:28:14 2017 Revert of cros: Fix keyboard navigation focus get lost when system tray set to invisible on oobe (patchset #1 id:1 of https://codereview.chromium.org/2794153002/ ) Reason for revert: AutofillInteractiveTest.AutofillAfterReload became flaky right after this landed. The test involves focus (FocusFirstNameField()) and the change also involves focus, so there is likely a connection. BUG= 708861 Original issue's description: > cros: Fix keyboard navigation focus get lost when system tray set to invisible on oobe > > Changes: > (1) add tray->visible() check in WebUILoginView::TakeFocus(). > (2) add else branch to avoid an invisible focus stop. > > BUG= 707977 > TEST=test that focus loop works > > Review-Url: https://codereview.chromium.org/2794153002 > Cr-Commit-Position: refs/heads/master@{#461741} > Committed: https://chromium.googlesource.com/chromium/src/+/43c00b6dfca02767efa66d7fb110c7cbf28bc019 TBR=xiyuan@chromium.org,warx@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 707977 Review-Url: https://codereview.chromium.org/2801853003 Cr-Commit-Position: refs/heads/master@{#462355} [modify] https://crrev.com/53436789712c58d9f7d512e6615b4acf46e52f28/chrome/browser/chromeos/login/ui/webui_login_view.cc
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f645439ea16d03a4c70722d72f611a85eeea5ffd commit f645439ea16d03a4c70722d72f611a85eeea5ffd Author: warx <warx@chromium.org> Date: Thu Apr 06 21:41:44 2017 reland: cros: Fix keyboard navigation focus get lost when system tray set to invisible on oobe Changes: Reland reverted CL: crrev.com/2794153002 as it is not the reason causing the flaky test: AutofillInteractiveTest.AutofillAfterReload. TBR=xiyuan@chromium.org, foolip@chromium.org BUG= 707977 test=none Review-Url: https://codereview.chromium.org/2806583002 Cr-Commit-Position: refs/heads/master@{#462630} [modify] https://crrev.com/f645439ea16d03a4c70722d72f611a85eeea5ffd/chrome/browser/chromeos/login/ui/webui_login_view.cc
,
May 8 2017
Chrome OS 9532.0.0, 60.0.3092.0
,
May 15 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Apr 4 2017