New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 707972 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Kernel doesn't permit disabling legacy keyboard wakeup

Project Member Reported by derat@chromium.org, Apr 3 2017

Issue description

Per Benson, it sounds like powerd is unable to prevent keyboards on some convertible devices (e.g. caroline) from acting as wake sources. It sounds like the AT legacy keyboard driver may lack the ability to control wakeups via the wakeup sysfs attribute, e.g. /sys/class/input/event3/device/device/power/wakeup.

The result of this is that the keyboard will wake these systems while they're in tablet mode, which is non-ideal.

Tangentially related is  issue 703691 , which tracked powerd disabling keyboard wakeup while in tablet mode but not inhibiting the keyboard (since we receive power button events through it).

Sameer, assigning to you to find an owner.
 
Cc: gwendal@chromium.org sha...@chromium.org daisuke@chromium.org snanda@chromium.org
Owner: bleung@chromium.org
That suppression is generally done in the EC.  Benson to take a look to help understand why Caroline is behaving differently than Reef (where the keyboard wake suppression does happen in tablet mode).

Comment 2 by derat@chromium.org, May 1 2017

Labels: M-60
Status: Assigned (was: Untriaged)
Benson, can you comment on this? The behavior on caroline was pretty subpar as a result the last time that I looked. Is the plan to work around this in the EC there?

Comment 3 by gwendal@google.com, May 1 2017

Normally, while in S3, the EC will not wake up the AP on keypress if the lid angle is > 180 degree.

Looking at issue where it does not work. The reason the AP is woken up is that the lid angle may not calculated properly, if an accelerometer is stuck. (see b/35550738, b/35774911)

However, all changes needed for kinoix accel to support stuck accels are in 7820.286.0, 
Meanwhile feedback https://feedback.corp.google.com/product/208/neutron?lView=rd&lReport=58962763520 indicates there is still an issue.




Sign in to add a comment