New issue
Advanced search Search tips

Issue 707963 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 663787
Owner: ----
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

git-cl: use push options instead of %NOTIFY=True

Project Member Reported by aga...@chromium.org, Apr 3 2017

Issue description

Now that b/34810198 is fixed, we can update git-cl to use push options instead of weird ref parameters (cleanliness yay!) and perhaps instead of the api (speed yay!).
 
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/0267fd2c290a4ca2300d58abf53af32f8324e285

commit 0267fd2c290a4ca2300d58abf53af32f8324e285
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Wed Apr 05 12:39:00 2017

git cl upload for Gerrit: use push options instead of refspec.

This removes limitation of no special chars in patchset titles.

BUG= chromium:663787 , chromium:707963 , gerrit:5184 
R=sergiyb@chromium.org,agable@chromium.org
TEST=uploaded this CL using depot_tools with this patch :)

Change-Id: I5d684d0a0aa286a45ff99cca6d57aefa8436cd0f
Reviewed-on: https://chromium-review.googlesource.com/468926
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@google.com>

[modify] https://crrev.com/0267fd2c290a4ca2300d58abf53af32f8324e285/tests/git_cl_test.py
[modify] https://crrev.com/0267fd2c290a4ca2300d58abf53af32f8324e285/git_cl.py

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/febbae9d2edf9b7861dcee602ae6eaecb25d3e09

commit febbae9d2edf9b7861dcee602ae6eaecb25d3e09
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Wed Apr 05 15:05:33 2017

Revert "git cl upload for Gerrit: use push options instead of refspec."

This reverts commit 0267fd2c290a4ca2300d58abf53af32f8324e285.

Reason for revert: seems to have changed some behavior as reported by SKIA.

Original change's description:
> git cl upload for Gerrit: use push options instead of refspec.
> 
> This removes limitation of no special chars in patchset titles.
> 
> BUG= chromium:663787 , chromium:707963 , gerrit:5184 
> R=​sergiyb@chromium.org,agable@chromium.org
> TEST=uploaded this CL using depot_tools with this patch :)
> 
> Change-Id: I5d684d0a0aa286a45ff99cca6d57aefa8436cd0f
> Reviewed-on: https://chromium-review.googlesource.com/468926
> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Sergiy Byelozyorov <sergiyb@google.com>
> 

TBR=agable@chromium.org,sergiyb@google.com,tandrii@chromium.org,sergiyb@chromium.org,borenet@chromium.org,chromium-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:663787 , chromium:707963 , gerrit:5184 

Change-Id: I3306091b14b97a200150389d0480b69120af8c61
Reviewed-on: https://chromium-review.googlesource.com/469006
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/febbae9d2edf9b7861dcee602ae6eaecb25d3e09/tests/git_cl_test.py
[modify] https://crrev.com/febbae9d2edf9b7861dcee602ae6eaecb25d3e09/git_cl.py

Comment 4 by aga...@chromium.org, May 15 2017

Mergedinto: 663787
Status: Duplicate (was: Available)

Sign in to add a comment