New issue
Advanced search Search tips

Issue 707940 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

[Braille] Need support for additional keys on the braille display (ctrl, alt, delete, enter)

Project Member Reported by lpalmaro@chromium.org, Apr 3 2017

Issue description

Chrome Version: 59.0.3055.0
OS: Chrome

Would be great to figure out a way to support important keys like Ctrl, Alt, Delete, Enter consistently on braille displays that support this. Once we figure out a way to do so, we need to add this to our documentation to be clear about which displays support the use of these keys. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/566a5a2b7579c276d818914b2f30688960c3aa98

commit 566a5a2b7579c276d818914b2f30688960c3aa98
Author: dtseng <dtseng@chromium.org>
Date: Mon Apr 17 19:41:08 2017

Support braille dot or chorded typing conversions to standard keyboard keys

This cl enables flexible keyboard commands from a braille display perkins keyboard.

Incrmental modifier typing:
A user can press the following keys to build a shortcut
- space+dots 2-5: control
space+dots 3-6: alt
space+dots 3-7: shift

for convenience:
- space+dots 2-5-7: control+shift
space+dots 3-6-7: alt+shift

For example:
type space+dots 3-7, space+dots 3-6, dots 3-4-5 (s) to move to the status tray. Alternatively, press space+dots 3-6-7, dots 3-4-5 (s).

It is now possible to perform common commands like alt+f, ctrl+1-9, and more.

Chorded key mappings:
space+dot 7: backspace
space+dots 3-5: tab
space+dots 1-3-5-6: escape
space+dots 4-6: enter
These set of commands do not require a incremental modifier be pressed previously.

TEST=invoke various modifiers
ctrl+l, alt+f, ctrl+t, alt+shift+l, and more. Verify the expected action occurs.
In addition, use chorded commands such as tab, escape, shift+tab (mixture of the two types above). Verify expected action occurs.

BUG= 707940 , 707937 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2817313002
Cr-Commit-Position: refs/heads/master@{#464984}

[modify] https://crrev.com/566a5a2b7579c276d818914b2f30688960c3aa98/chrome/browser/resources/chromeos/chromevox/BUILD.gn
[add] https://crrev.com/566a5a2b7579c276d818914b2f30688960c3aa98/chrome/browser/resources/chromeos/chromevox/braille/braille_key_event_rewriter.js
[modify] https://crrev.com/566a5a2b7579c276d818914b2f30688960c3aa98/chrome/browser/resources/chromeos/chromevox/braille/braille_key_types.js
[modify] https://crrev.com/566a5a2b7579c276d818914b2f30688960c3aa98/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs
[modify] https://crrev.com/566a5a2b7579c276d818914b2f30688960c3aa98/chrome/browser/resources/chromeos/chromevox/host/chrome/braille_background.js
[modify] https://crrev.com/566a5a2b7579c276d818914b2f30688960c3aa98/chrome/browser/resources/chromeos/chromevox/tools/jscompilerwrapper.py

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8bfbee9bffdb2827fc28d84dc44c13c349ce317

commit d8bfbee9bffdb2827fc28d84dc44c13c349ce317
Author: dtseng <dtseng@chromium.org>
Date: Tue Apr 18 14:28:16 2017

Improve Learn Mode for braille

- output dots ... chord, when we don't have a mapping and a user presses a chord combination
- when a user types a dot pattern, back-translate the pattern using the current braille table and output.
For example, if a user presses dot 4 in English computer braille, they will hear "@".
- when a user types a chord that maps to a command or modifier, they will receive that as output.
For example, "control" (dots 2-5 chord), "backspace" (dot 7 chord)

TEST=open Learn Mode. Press various braille keys.
BUG= 707927 , 707940 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2819273002
Cr-Commit-Position: refs/heads/master@{#465231}

[modify] https://crrev.com/d8bfbee9bffdb2827fc28d84dc44c13c349ce317/chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js

Comment 3 by dtseng@chromium.org, Apr 18 2017

Owner: lpalmaro@chromium.org
Status: fixed (was: Assigned)
To lpalmaro for documentation.

Comment 4 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 5 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61
Status: Verified (was: Fixed)
The mappings are working fine on the braille keyaboard

Sign in to add a comment