New issue
Advanced search Search tips

Issue 707933 link

Starred by 2 users
Status: Verified
Owner:
dtseng@chromium.org
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

[Braille] Need to switch to computer braille when in email field and indicate so on display

Project Member Reported by lpalmaro@chromium.org, Apr 3 2017 
Chrome Version: 59.0.3055.0
OS: Chrome

This bug is to track the work to switch to computer braille when in an email field. We also need to indicate this switch on the braille display so it's clear to the user. Once complete, we should also make this clear in our documentation.

Comment 1 by lpalmaro@chromium.org, Apr 3 2017

Labels: OS-Chrome
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e49774a1cca97ac55ee4f9af730cc36cb4b79015

commit e49774a1cca97ac55ee4f9af730cc36cb4b79015
Author: dtseng <dtseng@chromium.org>
Date: Wed Apr 12 17:27:56 2017

Switch to selected 8-dot braille table in email and url text fields

BUG= 707933 
TEST=verify manually email and url type inputs have 8-dot i/o. Verify that switching away from these fields reverts back to user selected table. OutputE2ETest revision for automation.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2813743002
Cr-Commit-Position: refs/heads/master@{#464066}

[modify] https://crrev.com/e49774a1cca97ac55ee4f9af730cc36cb4b79015/chrome/browser/resources/chromeos/chromevox/braille/braille_translator_manager.js
[modify] https://crrev.com/e49774a1cca97ac55ee4f9af730cc36cb4b79015/chrome/browser/resources/chromeos/chromevox/braille/braille_translator_manager_test.extjs
[modify] https://crrev.com/e49774a1cca97ac55ee4f9af730cc36cb4b79015/chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js
[modify] https://crrev.com/e49774a1cca97ac55ee4f9af730cc36cb4b79015/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js
[modify] https://crrev.com/e49774a1cca97ac55ee4f9af730cc36cb4b79015/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
[modify] https://crrev.com/e49774a1cca97ac55ee4f9af730cc36cb4b79015/chrome/browser/resources/chromeos/chromevox/cvox2/background/chromevox_state.js
[modify] https://crrev.com/e49774a1cca97ac55ee4f9af730cc36cb4b79015/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js
[modify] https://crrev.com/e49774a1cca97ac55ee4f9af730cc36cb4b79015/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs
[modify] https://crrev.com/e49774a1cca97ac55ee4f9af730cc36cb4b79015/chrome/browser/resources/chromeos/chromevox/host/chrome/braille_background.js
[modify] https://crrev.com/e49774a1cca97ac55ee4f9af730cc36cb4b79015/chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd
[modify] https://crrev.com/e49774a1cca97ac55ee4f9af730cc36cb4b79015/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cd8ddf786165529d28e50c4bc14a83eb0bcf39f

commit 5cd8ddf786165529d28e50c4bc14a83eb0bcf39f
Author: dtseng <dtseng@chromium.org>
Date: Thu Apr 13 00:23:53 2017

Add a command to toggle between 6 and 8 dot braille.

BUG= 707933 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2813233002
Cr-Commit-Position: refs/heads/master@{#464220}

[modify] https://crrev.com/5cd8ddf786165529d28e50c4bc14a83eb0bcf39f/chrome/browser/resources/chromeos/chromevox/braille/braille_translator_manager.js
[modify] https://crrev.com/5cd8ddf786165529d28e50c4bc14a83eb0bcf39f/chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json
[modify] https://crrev.com/5cd8ddf786165529d28e50c4bc14a83eb0bcf39f/chrome/browser/resources/chromeos/chromevox/chromevox/background/prefs.js
[modify] https://crrev.com/5cd8ddf786165529d28e50c4bc14a83eb0bcf39f/chrome/browser/resources/chromeos/chromevox/common/command_store.js
[modify] https://crrev.com/5cd8ddf786165529d28e50c4bc14a83eb0bcf39f/chrome/browser/resources/chromeos/chromevox/cvox2/background/braille_command_handler.js
[modify] https://crrev.com/5cd8ddf786165529d28e50c4bc14a83eb0bcf39f/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js
[modify] https://crrev.com/5cd8ddf786165529d28e50c4bc14a83eb0bcf39f/chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd

Comment 4 by dtseng@chromium.org, Apr 18 2017

Status: fixed (was: Assigned)
Brief description of feature:
When a user encounters either an email or url text field (e.g. the address bar), they will automatically be switched to their 8-dot table (from options page). On the display itself, theoutput is also using the 8-dot braille table and the text field has an '8dot' label at the end. At this point, both input and output is expected to be in 8-dot braille according to the selected table.

Comment 5 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 6 by pbath...@chromium.org, Jul 10 2017

Status: Verified (was: Fixed)
As per #4
►

Sign in to add a comment