New issue
Advanced search Search tips

Issue 707925 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocking:
issue 770175



Sign in to add a comment

Login suggested but doesn't fill

Project Member Reported by pinkerton@chromium.org, Apr 3 2017

Issue description

Chrome Version: M59dev
OS: iOS10.3 iPadAir.

- have a saved account (username/password) at forums.stevehoffman.tv
- go to http://forums.stevehoffman.tv/forums/audio-hardware.5/
- at top of page, tap "log in or signup" tab
- tap to focus "name or email address" text field
- in keyboard accessory view, tap saved username

expected:
- username and password fill in login form

actual
- nothing happens
 

Comment 1 by sczs@chromium.org, Apr 5 2017

Cc: melandory@chromium.org
Labels: M-58
Owner: vabr@chromium.org
Status: Assigned (was: Untriaged)
Hi vabr@ , melandory@ could you please take a look.

Comment 2 by vabr@chromium.org, Apr 6 2017

Labels: Hotlist-Polish
Owner: ----
Status: Available (was: Assigned)
As explained to lindsayw@ in an e-mail, I am moving these bugs to our TODO list, and reducing some unnecessary noise they cause.
Note that this works on iPhone (password is autofilled, don't have to tap anything), but fails on iPad. 
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 11 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by sczs@chromium.org, Apr 11 2018

Cc: -mard...@chromium.org -melandory@chromium.org -battre@chromium.org -kolos@chromium.org -privard@chromium.org vabr@chromium.org dvadym@chromium.org
Status: Available (was: Untriaged)
ccing you on this old passwords bug, please check if still relevant when you have time.

Comment 6 by vabr@chromium.org, Apr 13 2018

Blocking: 770175
Cc: -vabr@chromium.org
Labels: -Pri-2 -M-58 Pri-3
I could still reproduce with 67.0.3396.0 (Developer Build) unknown (64-bit) on iPad Air 2 (11.0). I used a custom build to have a password saved (https://crrev.com/c/946350). On tapping the username field I did not even get the keyboard accessory hint. On tapping the password I did get the hint, but it did not fill the form.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a78f7f38b7c61ccf4d4950e5b771357a729509b

commit 6a78f7f38b7c61ccf4d4950e5b771357a729509b
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Wed Apr 18 13:31:49 2018

Skip non-text field in form parsing.

Password Manager has to use only text fields. This CL implements
skipping all other fields during form parsing. It already works this
way in form parsing in the Renderer process.

Bug:  807623 ,  707925 

Change-Id: I31e5f06a3a2bc8ee8368a0e2df84f58abc900faf
Reviewed-on: https://chromium-review.googlesource.com/1013580
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551656}
[modify] https://crrev.com/6a78f7f38b7c61ccf4d4950e5b771357a729509b/components/autofill/core/common/form_field_data.cc
[modify] https://crrev.com/6a78f7f38b7c61ccf4d4950e5b771357a729509b/components/autofill/core/common/form_field_data.h
[modify] https://crrev.com/6a78f7f38b7c61ccf4d4950e5b771357a729509b/components/autofill/core/common/form_field_data_unittest.cc
[modify] https://crrev.com/6a78f7f38b7c61ccf4d4950e5b771357a729509b/components/password_manager/core/browser/form_parsing/ios_form_parser.cc
[modify] https://crrev.com/6a78f7f38b7c61ccf4d4950e5b771357a729509b/components/password_manager/core/browser/form_parsing/ios_form_parser_unittest.cc

Comment 8 by dvadym@chromium.org, Apr 18 2018

Status: Fixed (was: Available)

Sign in to add a comment