New issue
Advanced search Search tips

Issue 707924 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Apr 2017
Cc:
seanmccullough@chromium.org
martiniss@chromium.org
zhangtiff@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: ----



Sign in to add a comment

make relnotes pull in changes from transitive dependencies

Project Member Reported by seanmccullough@chromium.org, Apr 3 2017 
Currently 'make relnotes' only looks at the current source tree.

Sometimes we need to know if important changes from other libraries are included in a release (say, auth library support). These often affect
users too.

Not sure how to do this properly, but one way may be to look at DEPS or analyze go imports (using go/ast package for instance).
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d59a58686be99144122b5fa8c450f7053fb70b1b

commit d59a58686be99144122b5fa8c450f7053fb70b1b
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Mon Apr 17 17:24:03 2017

[relnotes] check logs of multiple git dirs

Bug:707924

Change-Id: Iebb6db8e6c4d6a009eb099082a83c95e57ff0990
Reviewed-on: https://chromium-review.googlesource.com/478811
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/d59a58686be99144122b5fa8c450f7053fb70b1b/go/src/infra/appengine/sheriff-o-matic/Makefile
[modify] https://crrev.com/d59a58686be99144122b5fa8c450f7053fb70b1b/go/src/infra/tools/relnotes/relnotes.go

Comment 2 by seanmccullough@google.com, Apr 17 2017

Status: Fixed (was: Available)
this fix doesn't automatically determine the other dirs, but it's good enough that you can now specify them manually.
►

Sign in to add a comment