This bug tracks issues mentioned in: https://groups.google.com/a/chromium.org/d/msg/blink-dev/W-Q1yWW-zas/w8XMfQOHDAAJ 1. Add links to spec in InputEvent.idl and InputEventInit.idl 2. File WebKit bugs for the missing attributes * https://bugs.webkit.org/show_bug.cgi?id=170414 * https://bugs.webkit.org/show_bug.cgi?id=170416 3. Add links to spec in StaticRange.idl 4. Add web-platform-tests for StaticRange
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3279fff89f248e0bf264586cc2c71f19d97de40 commit b3279fff89f248e0bf264586cc2c71f19d97de40 Author: chongz <chongz@chromium.org> Date: Tue Apr 04 15:27:45 2017 [InputEvent] Update spec link for StaticRange.idl and use unsigned offset This CL: 1. Add link to latest spec in StaticRange.idl * https://garykac.github.io/staticrange/#interface-staticrange 2. Replace |int start/endOffset| with |unsigned start/endOffset| to match spec BUG= 707913 Review-Url: https://codereview.chromium.org/2793093002 Cr-Commit-Position: refs/heads/master@{#461725} [modify] https://crrev.com/b3279fff89f248e0bf264586cc2c71f19d97de40/third_party/WebKit/Source/core/dom/StaticRange.cpp [modify] https://crrev.com/b3279fff89f248e0bf264586cc2c71f19d97de40/third_party/WebKit/Source/core/dom/StaticRange.h [modify] https://crrev.com/b3279fff89f248e0bf264586cc2c71f19d97de40/third_party/WebKit/Source/core/dom/StaticRange.idl [modify] https://crrev.com/b3279fff89f248e0bf264586cc2c71f19d97de40/third_party/WebKit/Source/core/dom/StaticRangeTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75eb6237332971699fb1021b206ad049c1de30a4 commit 75eb6237332971699fb1021b206ad049c1de30a4 Author: chongz <chongz@chromium.org> Date: Tue Apr 04 17:29:16 2017 [InputEvent] Update spec links for InputEvent(Init).idl BUG= 707913 Review-Url: https://codereview.chromium.org/2795783002 Cr-Commit-Position: refs/heads/master@{#461767} [modify] https://crrev.com/75eb6237332971699fb1021b206ad049c1de30a4/third_party/WebKit/Source/core/events/InputEvent.idl [modify] https://crrev.com/75eb6237332971699fb1021b206ad049c1de30a4/third_party/WebKit/Source/core/events/InputEventInit.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2b8278dd5aaf5a6ec415aa5e7dd828f17b644f6 commit e2b8278dd5aaf5a6ec415aa5e7dd828f17b644f6 Author: chongz <chongz@chromium.org> Date: Fri Apr 14 03:14:23 2017 [InputEvent] Make StaticRange immutable and move tests to wpt According to the intent-to-ship in blink-dev there is still ongoing discussion about StaticRange on whether we should make attributes mutable. However this shouldn't block InputEvent and we should ship the immutable version first to keep interop with WebKit. This CL removed |Constructor()| |setStart()|, |setEnd()|, |toRange()| and made attributes readonly. See WebKit IDL: https://github.com/WebKit/webkit/blob/1bfaaab3e7bf61dcad32c44a1399914987f9018f/Source/WebCore/dom/StaticRange.idl StaticRange spec: http://garykac.github.io/staticrange/index.html#interface-staticrange Discussion: https://groups.google.com/a/chromium.org/d/msg/blink-dev/W-Q1yWW-zas/UrqnyVAIDQAJ BUG= 707913 Review-Url: https://codereview.chromium.org/2791373002 Cr-Commit-Position: refs/heads/master@{#464665} [add] https://crrev.com/e2b8278dd5aaf5a6ec415aa5e7dd828f17b644f6/third_party/WebKit/LayoutTests/external/wpt/staticrange/idlharness-expected.txt [add] https://crrev.com/e2b8278dd5aaf5a6ec415aa5e7dd828f17b644f6/third_party/WebKit/LayoutTests/external/wpt/staticrange/idlharness.html [modify] https://crrev.com/e2b8278dd5aaf5a6ec415aa5e7dd828f17b644f6/third_party/WebKit/LayoutTests/external/wpt/uievents/constructors/inputevent-constructor.html [delete] https://crrev.com/426ea5dd2cf7061a7860a34d502f2c191a343a8e/third_party/WebKit/LayoutTests/fast/dom/StaticRange/staticrange-constructor.html [delete] https://crrev.com/426ea5dd2cf7061a7860a34d502f2c191a343a8e/third_party/WebKit/LayoutTests/fast/dom/StaticRange/staticrange-no-mutate.html [modify] https://crrev.com/e2b8278dd5aaf5a6ec415aa5e7dd828f17b644f6/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/e2b8278dd5aaf5a6ec415aa5e7dd828f17b644f6/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/e2b8278dd5aaf5a6ec415aa5e7dd828f17b644f6/third_party/WebKit/Source/core/dom/StaticRange.idl
Comment 1 by bugdroid1@chromium.org
, Apr 4 2017