field trial test config uses win and not windows |
||||
Issue descriptionThis makes it inconsistant with server side tools. Changes need to be made here: https://codesearch.chromium.org/chromium/src/components/variations/field_trial_config/BUILD.gn?type=cs&q=fieldtrial_testing_config&l=28 https://codesearch.chromium.org/chromium/src/tools/variations/fieldtrial_to_struct.py?type=cs&l=119 Could do prefixing to change it to windows.
,
Apr 4 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 4 2018
Still available.
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad77b789e40639b5d0d70875d7cc0aa4a506473d commit ad77b789e40639b5d0d70875d7cc0aa4a506473d Author: Paul Miller <paulmiller@google.com> Date: Wed Jul 11 20:07:43 2018 Variations: Rename 'win' to 'windows' in testing config This is to match server-side tools. Since GN uses "win", there must still be some boundary where "win" is converted to "windows"; move the conversion from fieldtrial_to_struct.py to field_trial_config/BUILD.gn. Also add "android_webview" to the field trial config presubmit. BUG= 707911 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I73c2d2fa98410e32ae77d053098d704ee40378ac Reviewed-on: https://chromium-review.googlesource.com/1130348 Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#574297} [modify] https://crrev.com/ad77b789e40639b5d0d70875d7cc0aa4a506473d/components/variations/field_trial_config/BUILD.gn [modify] https://crrev.com/ad77b789e40639b5d0d70875d7cc0aa4a506473d/testing/variations/PRESUBMIT.py [modify] https://crrev.com/ad77b789e40639b5d0d70875d7cc0aa4a506473d/testing/variations/README.md [modify] https://crrev.com/ad77b789e40639b5d0d70875d7cc0aa4a506473d/testing/variations/fieldtrial_testing_config.json [modify] https://crrev.com/ad77b789e40639b5d0d70875d7cc0aa4a506473d/tools/chrome_proxy/webdriver/variations_combinations.py [modify] https://crrev.com/ad77b789e40639b5d0d70875d7cc0aa4a506473d/tools/perf/core/perf_benchmark.py [modify] https://crrev.com/ad77b789e40639b5d0d70875d7cc0aa4a506473d/tools/variations/fieldtrial_to_struct.py [modify] https://crrev.com/ad77b789e40639b5d0d70875d7cc0aa4a506473d/tools/variations/fieldtrial_to_struct_unittest.py [modify] https://crrev.com/ad77b789e40639b5d0d70875d7cc0aa4a506473d/tools/variations/fieldtrial_util.py [modify] https://crrev.com/ad77b789e40639b5d0d70875d7cc0aa4a506473d/tools/variations/fieldtrial_util_unittest.py [modify] https://crrev.com/ad77b789e40639b5d0d70875d7cc0aa4a506473d/tools/variations/unittest_data/test_config.json
,
Jul 11
|
||||
►
Sign in to add a comment |
||||
Comment 1 by rkaplow@chromium.org
, Apr 3 2017