New issue
Advanced search Search tips

Issue 707896 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

ModemManager: novatel-lte modem plugin is missing since M58

Project Member Reported by benchan@chromium.org, Apr 3 2017

Issue description

Upstream commit (https://cgit.freedesktop.org/ModemManager/ModemManager/commit/?id=f9c63bfa058bdab29e00f13a0bedf4b4af39797e) accidentally renamed the the Novatel-LTE modem plugin from 'libmm-plugin-novatel-lte.so' to 'libmm-plugin-novatel_lte.so'. The renamed plugin is filtered out by our ebuild, and thus ends up missing in our image.

The plugin is needed to support the Novatel LTE modem on the Link device.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/modemmanager-next/+/c3cded2efc1c82a18639ae4109d6dbc2d6a95502

commit c3cded2efc1c82a18639ae4109d6dbc2d6a95502
Author: Ben Chan <benchan@chromium.org>
Date: Tue Apr 04 10:02:45 2017

novatel-lte: revert to original plugin library name

Commit f9c63bfa0 "build,plugins: update build rules" accidentally
changed the Novatel LTE plugin from 'libmm-plugins-novatel-lte.so' to
'libmm-plugins-novatel_lte.so'. The name becomes inconsistent with other
plugin names.

This patch has been submitted to upstream:
https://lists.freedesktop.org/archives/modemmanager-devel/2017-April/004398.html

BUG= chromium:707896 
TEST=Verify that libmm-plugin-novatel-lte.so is installed.

Change-Id: Ie5ad7c060366141bab32855760df2c61744995de
Reviewed-on: https://chromium-review.googlesource.com/466686
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/c3cded2efc1c82a18639ae4109d6dbc2d6a95502/plugins/Makefile.am

Labels: Merge-Request-58
Status: Fixed (was: Started)
Labels: -Merge-Request-58 Merge-Approved-58
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 4 2017

Labels: merge-merged-release-R58-9334.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/modemmanager-next/+/6159044c8f554a3b75a2ae023e9102a1ac796cc6

commit 6159044c8f554a3b75a2ae023e9102a1ac796cc6
Author: Ben Chan <benchan@chromium.org>
Date: Tue Apr 04 21:56:41 2017

novatel-lte: revert to original plugin library name

Commit f9c63bfa0 "build,plugins: update build rules" accidentally
changed the Novatel LTE plugin from 'libmm-plugins-novatel-lte.so' to
'libmm-plugins-novatel_lte.so'. The name becomes inconsistent with other
plugin names.

This patch has been submitted to upstream:
https://lists.freedesktop.org/archives/modemmanager-devel/2017-April/004398.html

BUG= chromium:707896 
TEST=Verify that libmm-plugin-novatel-lte.so is installed.

Change-Id: Ie5ad7c060366141bab32855760df2c61744995de
Reviewed-on: https://chromium-review.googlesource.com/466686
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit c3cded2efc1c82a18639ae4109d6dbc2d6a95502)
Reviewed-on: https://chromium-review.googlesource.com/467566
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/6159044c8f554a3b75a2ae023e9102a1ac796cc6/plugins/Makefile.am

Labels: -Merge-Approved-58

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment