arc: Crash on activating Play Store in deferred mode. |
|||||
Issue descriptionInner bug: b/36384987 Repro: Enable PlayStore and wait OptIn completed. Sign out and Sign In again. While ARC is not loaded press pinned Play Store icon on the shelf. Chrome crashes. It is expected that spinning animation is shown while ARC is loaded. No crash happen with other apps started in deferred mode.
,
Apr 3 2017
,
Apr 3 2017
,
Apr 4 2017
,
Apr 4 2017
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6834c45baabad9b9f99d2750db94880147ccf38 commit a6834c45baabad9b9f99d2750db94880147ccf38 Author: khmel <khmel@chromium.org> Date: Tue Apr 04 21:13:57 2017 arc: Fix crash activating Play Store in deferred mode. There are set of refactorings that makes using Play Store deferred launcher unsafe. Activating Play Store shortcut may cause replacing controller inline and this makes context of current object is invalid after the call. This CL fixes this issue by skipping access to object if Play Store was actually launched. TEST=Extended unit_tests BUG= 707895 Review-Url: https://codereview.chromium.org/2793223002 Cr-Commit-Position: refs/heads/master@{#461840} [modify] https://crrev.com/a6834c45baabad9b9f99d2750db94880147ccf38/chrome/browser/ui/ash/launcher/arc_playstore_shortcut_launcher_item_controller.cc [modify] https://crrev.com/a6834c45baabad9b9f99d2750db94880147ccf38/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
,
Apr 7 2017
Verified on 9438.0.0 / 59.0.3064.0 with repro steps in bug description. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by khmel@chromium.org
, Apr 3 2017