Issue 666119  has been merged into this issue.

sync up between Findit team and Ecosystem Infra team.

The NextAction date has arrived: 2017-12-11

Hi everyone! How's the Q1 planning going? Shall we have a quick sync on this task?

The mapped-out details are all in https://docs.google.com/document/d/1D74Avu19avncJLZFrEPj39FtK-NkTzsKCh_4IyTC5fs/edit

Assigned to chanli@ to follow up.

 Issue 650747  has been fixed, is there anything more needed for this to progress?

At Findit side, I need to implement the parser to parse the json_test_results_format. I plan to do this next week. I'll update the  bug 806002  when I have progress.

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/79e0cdcb73a57b4b3e8a710a7408a73c455a6417

commit 79e0cdcb73a57b4b3e8a710a7408a73c455a6417
Author: Chan <chanli@chromium.org>
Date: Wed May 30 23:49:41 2018

[Findit] Modify step_mapper to make sure it doesn't only work for one kind of test results.

Step_mapper checks test_reuslt['all_tests'] before, but this is a gtest specific logic, update the logic to be test_result type nutral.

Bug:  707891 
Change-Id: Idfda428dd4b29d13595be594fbf2f723e2e42d38
Reviewed-on: https://chromium-review.googlesource.com/1079813
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/79e0cdcb73a57b4b3e8a710a7408a73c455a6417/appengine/findit/waterfall/flake/step_mapper.py

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/981cbe0b51755736035e6a0caac1fad9ad859eb4

commit 981cbe0b51755736035e6a0caac1fad9ad859eb4
Author: Chan <chanli@chromium.org>
Date: Fri Jun 01 00:32:13 2018

[Findit] Check step_name to determine if a test step is supported by Flake Analyzer.

Bug:707891
Change-Id: I7b39e71fc698ed0045dec5b45ed973d5fd2796bf
Reviewed-on: https://chromium-review.googlesource.com/1081507
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/981cbe0b51755736035e6a0caac1fad9ad859eb4/appengine/findit/waterfall/flake/test/step_mapper_test.py
[modify] https://crrev.com/981cbe0b51755736035e6a0caac1fad9ad859eb4/appengine/findit/waterfall/flake/step_mapper.py

I am running some tests and here is a successful Findit analysis on a consistent test failure in webkit_layout_tests: https://15779-7ba6196-dot-waterfall-frontend-dot-findit-for-me.appspot.com/waterfall/build-failure?url=https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Win10/35742

I'll run more tests (both for findit analysis and flake analysis) to make sure it's stable.

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b31849e550e3598f2d1df5d488b7d729e9096156

commit b31849e550e3598f2d1df5d488b7d729e9096156
Author: Chan <chanli@chromium.org>
Date: Wed Jul 18 22:55:24 2018

[Findit] Use test_location if there is no failure log for a failed test.

Bug:  707891 
Change-Id: Ia225226e2a421685dbd2a58031d931a6b6fba420
Reviewed-on: https://chromium-review.googlesource.com/1141333
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[add] https://crrev.com/b31849e550e3598f2d1df5d488b7d729e9096156/appengine/findit/services/test_failure/test_results_service.py
[modify] https://crrev.com/b31849e550e3598f2d1df5d488b7d729e9096156/appengine/findit/services/test_failure/ci_test_failure.py
[modify] https://crrev.com/b31849e550e3598f2d1df5d488b7d729e9096156/appengine/findit/services/test_failure/extract_test_signal.py
[add] https://crrev.com/b31849e550e3598f2d1df5d488b7d729e9096156/appengine/findit/services/test_failure/test/test_results_service_test.py

I believed that we could close this bug, since Webkit layout tests were supported back in June.