Issue metadata
Sign in to add a comment
|
Accessibility label for most likely tile is read when in autosuggest mode and that element is not visible |
||||||||||||||||||||||
Issue descriptionApp Version: 59.0.3054.0 iOS Version: iOS 10.3 Device: iPhone7 URL: NTP Steps to reproduce: 1. Turn on Voice over 2. Open app, open a new tab and ensure there are 8 tiles showing (top sites, most likely or popular sites) 3. Start typing a search query in the omnibox, for example “cru” 3. Once autosuggest options are showing in the drop down, bring focus up the omnibox (from the keyboard) and swipe right and/or swipe left to iterate through all of the accessible items on the page - try both directions if the tile doesn’t get surfaced in the first round. Observed results: NTP tile title for last tile is spoken even though it’s not visible. Expected results: Tile title should not be spoken since that element is not “visible” Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: n/a Bug reproducible on Dolphin/Safari/Firefox: Firefox: n/a Bug reproducible on current stable build (App Version, iOS Version): Yes M57 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes M58 Link to video/image: https://drive.google.com/file/d/0By4O1f2IQqQ_Y0VtcEhEWUpoZXM/view https://drive.google.com/file/d/0By4O1f2IQqQ_c1QtZVFadmdyQlU/view
,
Apr 3 2017
,
Apr 5 2017
Issue 706984 has been merged into this issue.
,
Apr 6 2017
I am not sure to be the right owner for this. It seems related to omnibox suggestions. +justincohen/rohitrao for input.
,
May 5 2017
assigning to justin as omnibox owner.
,
Sep 27 2017
,
Dec 6 2017
,
Feb 23 2018
,
Aug 1
I've investigated this. Couple of thoughts: 0. This is not limited to NTP and content suggestions, the actual web content is also read when moving voiceover cursor through the popup 1. I seriously doubt voiceover users will ever use the suggestions at all. Suggestions are useful when you type and can see them while typing, but if you are listening to the keys on your keyboard when typing, I don't think you're going to switch focus to a different UI element to hear the suggestions. I would love to know if this is so. 2. The issue itself stems from BVC containing everything. The only way I found for this to not happen is to have a custom UIView subclass as BVC's |view|, and make BVC update its a11y elements every time it shows or hides a view. In this case we could: - have the top toolbar, the content, and the bottom toolbar the a11y elements - when the popup is displayed, only expose the top toolbar and the popup as a11y elements This is extremely complicated, because BVC shows everything, and it's hard to tell at which point something was shown or hidden in BVC. For example, BVC knows when the popup is shown because -addChildViewController: is called, but it doesn't know when it's dismissed. There are also non-view-controller elements displayed in BVC that we have to expose, such as infobars. Mark, what do you think about the solution in (2)? Do you think it's feasible at all? Is it possible to make this somewhat maintainable? Assigning to you for feedback.
,
Aug 7
Issue 792883 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by linds...@chromium.org
, Apr 3 2017