+Ganggui, the Android UI expert.

Please aim to fix this in M-59.

This is not a bug in current canary, right? we do not have dropdown for state for now as I know,

Anyway, the left and right views are expected to have different height since they are different and the dropdown view has hint pushed up. So we may want to display each of them in a single line.

Otherwise, you can try to set android:layout_gravity=bottom for the two views here when adding them to the linearlayout https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java?rcl=32fda6433bcc281eb4794b8715cf44edb3dd1ce2&l=341

Screenshot of the fix, please?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ba9b212af6288fea45140610770a198d0241a58

commit 4ba9b212af6288fea45140610770a198d0241a58
Author: parastoog <parastoog@google.com>
Date: Fri Apr 07 10:40:31 2017

Align text-fields/drop-down-fields on Payment Request form.

-- When we click on a text-field, the title text moves, so the best way
 to make it permanently aligned is to make all the drop-down fields
 take a full line.

BUG= 707860 

Review-Url: https://codereview.chromium.org/2791363002
Cr-Commit-Position: refs/heads/master@{#462831}

[modify] https://crrev.com/4ba9b212af6288fea45140610770a198d0241a58/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ca3add13622c453c70565b8a21255133bc39687

commit 7ca3add13622c453c70565b8a21255133bc39687
Author: sebsg <sebsg@chromium.org>
Date: Thu Apr 13 20:27:22 2017

Revert of A drop-down should take a line to be always aligned with text-fields. (patchset #2 id:20001 of https://codereview.chromium.org/2791363002/ )

Reason for revert:
The feature for which this CL was made was reverted, and this CL breaks the UI of the credit card editor. Both should be landed together when fixed.

Original issue's description:
> Align text-fields/drop-down-fields on Payment Request form.
>
> -- When we click on a text-field, the title text moves, so the best way
>  to make it permanently aligned is to make all the drop-down fields
>  take a full line.
>
> BUG= 707860 
>
> Review-Url: https://codereview.chromium.org/2791363002
> Cr-Commit-Position: refs/heads/master@{#462831}
> Committed: https://chromium.googlesource.com/chromium/src/+/4ba9b212af6288fea45140610770a198d0241a58

TBR=mathp@chromium.org,rouslan@chromium.org,parastoog@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 707860 

Review-Url: https://codereview.chromium.org/2819623002
Cr-Commit-Position: refs/heads/master@{#464527}

[modify] https://crrev.com/7ca3add13622c453c70565b8a21255133bc39687/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java

CL is merged in 59.  Marking as fixed for now.  Please reopen if any other work is needed.

kravula@, can you verify?  

Re-tested on M59-59.0.3071.25 build and attached testing screenshot.

State should be drop-down or text-field?

Deleted: Screenshot_20170425-133035.png 84.2 KB

	Screenshot_20170425-133035.png 84.2 KB View Download

It should be a textfield, since I reverted the CL. So everything is fine now :)

[Auto-generated comment by a script] We noticed that this issue is targeted for M-59; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-59 label, otherwise remove Merge-TBD label. Thanks.

The new screenshots.

Deleted: 2.jpg 60.3 KB

	2.jpg 60.3 KB View Download

Deleted: 1.png 44.0 KB

	1.png 44.0 KB View Download

That looks great, except the "State" field is typically on the right hand side.

Deleted: Screenshot_20170512-135415.png 103 KB

	Screenshot_20170512-135415.png 103 KB View Download

So it should be: first state and then the zip code?

It's different for every country. For US it's this:

[Name       ]
[Org        ]
[Street     ]
[City][State]
[Zip code   ]

This is based on https://codesearch.chromium.org/chromium/src/third_party/libaddressinput/src/cpp/src/region_data_constants.cc, which has "%N%n%O%n%A%n%C, %S %Z" format for US. Now that I look at it, it should really be [City][State][Zip code] on the same line. Not sure why that's not the case, but no need to worry about that particular bug for now.

For future reference, this is what we agreed on:
On Android, City should always take up the full line. For State and Zip, follow libaddresisnput.

Please, see  the previous screenshots for that.

LGTM

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/721a3c1132e02f2f45c4eab292ef4418ff384bf3

commit 721a3c1132e02f2f45c4eab292ef4418ff384bf3
Author: parastoog <parastoog@google.com>
Date: Wed May 17 21:18:35 2017

Improvements to the Payment Address Form UI

Vertically align a text field and a dropdown field on a single line,
in the payment request form.

Also, according to the UX designer, locality and dependent-locality
fields (city, .. ) need a full line, on the payment address form.

BUG= 707860 

Review-Url: https://codereview.chromium.org/2868313002
Cr-Commit-Position: refs/heads/master@{#472573}

[modify] https://crrev.com/721a3c1132e02f2f45c4eab292ef4418ff384bf3/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/721a3c1132e02f2f45c4eab292ef4418ff384bf3/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java
[modify] https://crrev.com/721a3c1132e02f2f45c4eab292ef4418ff384bf3/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDialog.java

Payment Address Form UI displayed different in M59-59.0.3071.71 (State is not drop down and City][State) and M60-60.0.3109.0(State is dropdown)

Looks like changes are not merged into M60 build

Here I am attaching testing screenshots for M59 and M60

Deleted: M60.png 165 KB

	M60.png 165 KB View Download

kravula@: Thank you for bringing this up. We forgot to notify you of changes in this UI. The two new changes are: (1) State/province/region is dropdown for countries where we know their list and (2) City is always on its own line. The dropdown remove ambiguity on whether the user should type in the full name of the state or its abbreviation. The city is in its own line because it can get quite long and would be hard to see if it was on the same line as, for example, state and zip code.

[Auto-generated comment by a script] We noticed that this issue is targeted for M-59; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-59 label, otherwise remove Merge-TBD label. Thanks.

No need for merges.