New issue
Advanced search Search tips

Issue 707851 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Remove duplicated code related to checkable rows in the Ash system menu

Project Member Reported by tdander...@chromium.org, Apr 3 2017

Issue description

Consider opportunities to share the code within UpdateCheckMark() (in the anonymous namespace of tray_accessibility.cc) with other detailed views in the Ash system menu (see CommonPaletteTool, for example).
 

Comment 1 by minch@chromium.org, Apr 5 2017

The logic of UpdateCheckMark() is used by three files,
1. ash/common/system/tray_accessibility.cc
2. ash/common/system/chromeos/audio/audio_detailed_view.cc
3. ash/common/system/chromeos/palette/common_palette_tool.cc

Can I add two files, named as following,
ash/common/system/utils.h
ash/common/system/utils.cc

To add maybe two functions, CheckMark(...) && UncheckMark(...). Each function maybe 3 -5 lines.

Status: Started (was: Assigned)
Status: Fixed (was: Started)
Labels: code-change
Status: Verified (was: Fixed)

Sign in to add a comment