Remove duplicated code related to checkable rows in the Ash system menu |
||||
Issue descriptionConsider opportunities to share the code within UpdateCheckMark() (in the anonymous namespace of tray_accessibility.cc) with other detailed views in the Ash system menu (see CommonPaletteTool, for example).
,
Apr 6 2017
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c345ab7d5a956251b46048138972883c89337d8e commit c345ab7d5a956251b46048138972883c89337d8e Author: minch <minch@chromium.org> Date: Fri Apr 07 22:23:39 2017 Reuse the code within UpdateCheckMark() Move UpdateCheckMark() from anonymous namespace of tray_accessibility.cc to tray_popup_utils.h Then, it can be reused by AudioDetailedView and CommonPaletteTool. BUG= 707851 Review-Url: https://codereview.chromium.org/2803893002 Cr-Commit-Position: refs/heads/master@{#463020} [modify] https://crrev.com/c345ab7d5a956251b46048138972883c89337d8e/ash/common/system/chromeos/audio/audio_detailed_view.cc [modify] https://crrev.com/c345ab7d5a956251b46048138972883c89337d8e/ash/common/system/chromeos/palette/common_palette_tool.cc [modify] https://crrev.com/c345ab7d5a956251b46048138972883c89337d8e/ash/common/system/tray/tray_popup_utils.cc [modify] https://crrev.com/c345ab7d5a956251b46048138972883c89337d8e/ash/common/system/tray/tray_popup_utils.h [modify] https://crrev.com/c345ab7d5a956251b46048138972883c89337d8e/ash/common/system/tray_accessibility.cc
,
Apr 10 2017
,
May 8 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by minch@chromium.org
, Apr 5 2017