New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 707847 link

Starred by 4 users
Status: Fixed
Owner:
ericrk@chromium.org
Closed: Apr 2017
Cc:
vmp...@chromium.org
keishi@chromium.org
haraken@chromium.org
ericrk@chromium.org
█ mbarowsky+gpuimage@chromium.org
cblume@chromium.org
enne@chromium.org
andrescj@chromium.org
khushals...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Clear CC Image Decode Cache on Page Navigation

Project Member Reported by ericrk@chromium.org, Apr 3 2017 
CC Image decode cache does not clear its caches on page navigation. This is inefficient, as nothing in the cache can be reached at this point. Manual testing indicates that the Skia Image IDs change, even if we navigate backwards.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e73df9aebdf6e7374791bc2d076b93ef7961eaa

commit 9e73df9aebdf6e7374791bc2d076b93ef7961eaa
Author: ericrk <ericrk@chromium.org>
Date: Tue Apr 04 21:38:50 2017

Clear Image Decode Cache on Navigation

We can't reach cache entries after a page navigation, so we should
clear them (even if unlocked). In the unlocked case this will help
ensure the right things get evicted.

R=vmpstr@chromium.org
BUG= 707847 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2795803002
Cr-Commit-Position: refs/heads/master@{#461847}

[modify] https://crrev.com/9e73df9aebdf6e7374791bc2d076b93ef7961eaa/cc/raster/image_hijack_canvas_unittest.cc
[modify] https://crrev.com/9e73df9aebdf6e7374791bc2d076b93ef7961eaa/cc/tiles/gpu_image_decode_cache.cc
[modify] https://crrev.com/9e73df9aebdf6e7374791bc2d076b93ef7961eaa/cc/tiles/gpu_image_decode_cache.h
[modify] https://crrev.com/9e73df9aebdf6e7374791bc2d076b93ef7961eaa/cc/tiles/gpu_image_decode_cache_unittest.cc
[modify] https://crrev.com/9e73df9aebdf6e7374791bc2d076b93ef7961eaa/cc/tiles/image_controller_unittest.cc
[modify] https://crrev.com/9e73df9aebdf6e7374791bc2d076b93ef7961eaa/cc/tiles/image_decode_cache.h
[modify] https://crrev.com/9e73df9aebdf6e7374791bc2d076b93ef7961eaa/cc/tiles/software_image_decode_cache.cc
[modify] https://crrev.com/9e73df9aebdf6e7374791bc2d076b93ef7961eaa/cc/tiles/software_image_decode_cache.h
[modify] https://crrev.com/9e73df9aebdf6e7374791bc2d076b93ef7961eaa/cc/tiles/software_image_decode_cache_unittest.cc
[modify] https://crrev.com/9e73df9aebdf6e7374791bc2d076b93ef7961eaa/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/9e73df9aebdf6e7374791bc2d076b93ef7961eaa/cc/trees/layer_tree_host.h
[modify] https://crrev.com/9e73df9aebdf6e7374791bc2d076b93ef7961eaa/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/9e73df9aebdf6e7374791bc2d076b93ef7961eaa/cc/trees/layer_tree_host_impl.h

Comment 2 by ericrk@chromium.org, Apr 5 2017

Status: Fixed (was: Started)
Looks like a reasonable memory reduction across a number of multi-page tests:
https://chromeperf.appspot.com/group_report?rev=461847

Comment 3 by haraken@chromium.org, Apr 6 2017 

Yay!!!!!!!!!

Comment 4 by vmp...@chromium.org, Apr 6 2017 

That's awesome! Thanks

Comment 5 by keishi@chromium.org, Apr 6 2017 

Amazing drop!! Thanks for working on this.

Comment 6 by ericrk@chromium.org, Apr 6 2017 

keishi@, thanks for finding this and letting me know about the issue!
►

Sign in to add a comment