New issue
Advanced search Search tips

Issue 707846 link

Starred by 1 user
Status: Fixed
Owner:
gangwu@chromium.org
Closed: Apr 2017
Cc:
edchin@chromium.org
rohitrao@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Re-enable testSyncTypedURLDeleteFromServer and testSyncTypedURLUpload

Project Member Reported by jif@chromium.org, Apr 3 2017 
Can reproduce locally on iPhone 6, iOS simulator 10.2.
Exception example:

../../ios/chrome/browser/ui/sync/sync_fake_server_egtest.mm:470: error: -[SyncFakeServerTestCase testSyncTypedURLUpload] : Exception: AssertionFailedException

Exception Name: AssertionFailedException
Exception Reason: (((success)) is true) failed
Exception Details: Actual count: 0; Expected count: 1; Name: http://not-a-real-site/

Comment 1 by rohitrao@chromium.org, Apr 3 2017

Cc: edchin@chromium.org rohitrao@chromium.org
Labels: -Pri-3 Pri-1
Owner: gangwu@chromium.org
I suspect this was a result of https://codereview.chromium.org/2787893003.  Looks like the desktop tests were updated with the new expectations, but not the iOS tests.

Failures are visible on the FYI waterfall at https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS.  We don't have EG tests running on the main waterfall yet.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3841ef227593b7d49d2b7010a8f405c842c7bb3e

commit 3841ef227593b7d49d2b7010a8f405c842c7bb3e
Author: jif <jif@chromium.org>
Date: Mon Apr 03 20:01:45 2017

Disable 2 sync tests failing on iOS.

TBR=msarda
BUG= 707846 

Review-Url: https://codereview.chromium.org/2794033003
Cr-Commit-Position: refs/heads/master@{#461514}

[modify] https://crrev.com/3841ef227593b7d49d2b7010a8f405c842c7bb3e/ios/chrome/browser/ui/sync/sync_fake_server_egtest.mm

Comment 3 by gangwu@chromium.org, Apr 5 2017

Status: Started (was: Assigned)
Hi rohitrao@, is there a way I can I can run my CL on chromium.fyi EarlGreyiOS?
my cl is https://codereview.chromium.org/2803463003/
I tried "git cl try -b EarlGreyiOS -m chromium.fyi", but got "Access denied".

Comment 4 by rohitrao@chromium.org, Apr 5 2017 

Can you try the bot named "ios-simulator-eg"?  You should also be able to trigger a try job from the web ui in codereview.

Comment 5 by gangwu@chromium.org, Apr 5 2017 

Thanks, rohitrao@, it works!
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/351ea8942e01f28a8f00359d772a4444e56f0de0

commit 351ea8942e01f28a8f00359d772a4444e56f0de0
Author: gangwu <gangwu@chromium.org>
Date: Wed Apr 05 17:15:34 2017

[Sync] Use un-expired time for testing

Don't use expired time since sync will filter out expired time, so use
Time::Now() instead.

BUG= 707846 

Review-Url: https://codereview.chromium.org/2803463003
Cr-Commit-Position: refs/heads/master@{#462127}

[modify] https://crrev.com/351ea8942e01f28a8f00359d772a4444e56f0de0/ios/chrome/browser/ui/sync/sync_fake_server_egtest.mm
[modify] https://crrev.com/351ea8942e01f28a8f00359d772a4444e56f0de0/ios/chrome/test/app/sync_test_util.mm

Comment 7 by gangwu@chromium.org, Apr 5 2017

Status: Fixed (was: Started)
The CL passed FYI waterfall run, https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/26187, so mark as fixed.
►

Sign in to add a comment